Implement undo for send now action in outbox message list #6332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/store/outbox/actions.js
Outdated
| @@ -105,4 +108,33 @@ export default { | |||
|
|
|||
| commit('deleteMessage', { id }) | |||
| }, | |||
|
|
|||
| async sendMessageWithUndo({ getters, dispatch }, { message }) { | |||
There was a problem hiding this comment.
nit: the action is async but can't be awaited. You could return a new promise at the end that calls the resolve callback when everything is done
st3iny
force-pushed
the
enh/6248/undo-send-now
branch
from
97e8758
to
bd8c3c5
Compare
|
/backport to stable1.12 |
|
@st3iny is there anything missing? |
This is done. I forgot to change the label. |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enh/6248/undo-send-now
branch
from
61dadcf
to
d778791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6248
The action "Send now" in the action menu of the outbox message list now works exactly the same way as the "Send now" button of the composer modal.