Change account settings to modal

[GretaD]

• Remove the client-side route that is now obsolete
• Remove the server-side route and controller method that is now obsolete
• Requires Allow an "extra" slot for the AppNavigationItem nextcloud-libraries/nextcloud-vue#1493
• Modal background overlay remains after closing the modal

[GretaD]

The master of Modal aka @skjnldsv, can you please me help a bit here, I'm clueless why modal its not working. If you click Account Settings nothing happens and no error is shown.

[skjnldsv]

DOn't you want to wait for Marco's SettingsModal?

[GretaD]

DOn't you want to wait for Marco's SettingsModal?

ohh was not aware that he was creating one. Sure :)

[skjnldsv]

ohh was not aware that he was creating one. Sure :)

nextcloud-libraries/nextcloud-vue#1286 :)

[ChristophWurst]

I think ESLint wants to tell you someting 😉

[ChristophWurst]

Code looks good, didn't test yet

[ChristophWurst]

not blocked anymore

[ChristophWurst]

• You can only open the modal once
• The pencil icon next to the email address does not work
• The old settings route is not removed from appinfo/routes.php

[marcoambrosini]

🎉

[marcoambrosini]

Needs rebase and fixup

[GretaD]

* You can only open the modal once

* The pencil icon next to the email address does not work

* The old settings route is not removed from `appinfo/routes.php`

fixed

[jancborchardt]

• The auto/manual switch doesn’t show properly:
  
• The headings "Alias settings", "Signature settings" and "Editor settings" are not needed. (I assume removing them will also fix the indent?)

[ChristophWurst]

* The headings "Alias settings", "Signature settings" and "Editor settings" are not needed. (I assume removing them will also fix the indent?)

so we're craming everything into a single stream again? I really like this change because it gives a better overview and allows you to find the relevant section more quickly.

[jancborchardt]

so we're craming everything into a single stream again? I really like this change because it gives a better overview and allows you to find the relevant section more quickly.

• It is a single stream even with this change, just with a navigation?
• The 3 first sections are directly visible in the modal, so the navigation is not really needed
• The headings were duplicating the actual headings in place "Account settings", "Signature" and "Writing mode", so this results in more noise, not more structure
• What we could actually do is move the massive part of connection settings on the bottom to something like 2nd-level settings.

For reference:

Before	After

[ChristophWurst]

The account form styling of the tabs is indeed a regression of this PR. It's fine on master. See https://github.com/nextcloud/mail/pull/1252/files?w=1 for the original PR that added and and the stylings that seem to have lost their effect.

[GretaD]

close on behalf of #4130