-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate app frontend to Vue #936
Conversation
530d696
to
8e4876d
Compare
e3abe22
to
1c1ef7c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #936 +/- ##
=========================================
Coverage ? 42.26%
Complexity ? 139
=========================================
Files ? 23
Lines ? 601
Branches ? 31
=========================================
Hits ? 254
Misses ? 347
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1c1ef7c
to
7abce9d
Compare
Note that having the compiled files as |
7abce9d
to
865da29
Compare
For Apache server this is done automatically since Nextcloud 27 (nextcloud/server#36057 and nextcloud/server#38688) for Nginx this is also documented for Nextcloud 27 (nextcloud/documentation#10575). So as this targets Nextcloud 28 it should be "safe". |
19bafc4
to
3f4f047
Compare
This comment was marked as resolved.
This comment was marked as resolved.
3f4f047
to
d20c666
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
cdff465
to
5de6509
Compare
Reimplement frontend settings and log entry actions * Move to `NcAppSettingsDialog` * Make table header sticky * Make table columns fixed width * Add actions to rows * Add modal to view raw data of log entry * Add helpers and settings store * Add store for fetching and polling log entries Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…sing functions * Allow polling (live log) * Allow downloading log files * Implement infinite scroll Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
And fix handling quoted log entries when parsing a file (did not even work in React) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Important: Note that the tests are run with timezone **not** set to UTC, this allows to test if there is a difference between local TZ and UTC. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…ts and parse even old exception types Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Use secondary button style for filtered columns * Minor typo in dialog name * Make table border and log level colors less annoying * Add header to app * Make `<hr>` look less bright * Only try to load entries from server if file logging is enabled * Clear local log entries when switching to server log * Make filter button primary when active * Add default name to downloaded log file * Remove 'hide raw entry' button * Datetime format on settings dialog * LogDetailsModal should display the information in vertical list on mobile * Move actions inside the details modal * Add name to settings button * Move copy actions in modal to the same row as the 'hide exception' button * Make sure only the table is scrolled and the settings button is always displayed Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
f0dd06d
to
4496515
Compare
/compile amend |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
4496515
to
9219831
Compare
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Rewrite of the frontend code using Typescript + Vue and building with Vite.
Changes ✨
CTRL+F
to block unified search (except when a11y shortcuts is configured).Resolves 🐛
Screenshots 🖼️
Screen recording 📹
logreader.mp4
(Note that the local log file did not magically appear but the upload dialog was simply not part of the recorded window 😉 )
Done ✔️
To do 🚧
Follow Up
RecycleScroller
(Problem: Unknown height of elements if expanded).