feat: Support multiple accounts #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
refactor/config
branch
from
042db62
to
4c4f1b5
Compare
provokateurin
force-pushed
the
refactor/config
branch
from
4c4f1b5
to
caf8267
Compare
provokateurin
force-pushed
the
feat/multi-account
branch
from
3c4f76d
to
b55d58c
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
feat/multi-account
branch
from
60577c0
to
8f0309b
Compare
kyteinsky
approved these changes
Aug 20, 2024
|
I don't know how many differences there are between the Gitlab and Github Integration, but could you also take a look at nextcloud/integration_github#87 @provokateurin ? That would be awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
This is quite a massive refactor and I don't think reading through the diff is useful.
I also fixed quite a lot of problems I found along the way (e.g. reference resolving without an account was calling apis that are only accessible with an account).
I had to drop some things as they are only added complexity (e.g. oauth login from dashboard and popup) and would have made things even more complicated.
I'm sorry to drop such a big PR, but splitting it into multiple (except for #89) was simply not possible.