Encrypt oauth client id/secret and user tokens #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julien-nc
commented
Oct 18, 2024
julien-nc
commented
- Encrypt some sensitive admin setting values (client id/secret)
- Encrypt tokens and refresh tokens of user accounts
- Migrate existing stored admin and user values
julien-nc
requested review from
kyteinsky,
marcelklehr and
provokateurin
and removed request for
marcelklehr
kyteinsky
reviewed
Oct 18, 2024
lib/Service/ConfigService.php
Outdated
| ) { | ||
| } | ||
|
|
||
| public function getEncryptedAppValue(string $key): string { |
There was a problem hiding this comment.
getClearAppValue would suit the naming convention
kyteinsky
approved these changes
Oct 18, 2024
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/encrypt-secrets
branch
from
fe76865
to
848dea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.