set psalm error level to 4

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
nextcloud · Sep 12, 2024 · 1cac997 · 1cac997
1 parent a8859a1
commit 1cac997
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 59 deletions.
diff --git a/psalm.xml b/psalm.xml
@@ -1,13 +1,13 @@
 <?xml version="1.0"?>
 <psalm
-	errorLevel="1"
+	errorBaseline="tests/psalm-baseline.xml"
+	errorLevel="4"
 	resolveFromConfigFile="true"
 	findUnusedBaselineEntry="true"
 	findUnusedCode="false"
 	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 	xmlns="https://getpsalm.org/schema/config"
 	xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
-	errorBaseline="tests/psalm-baseline.xml"
 >
 	<stubs>
 		<file name="tests/stub.phpstub" preloadClasses="true"/>

diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
@@ -6,43 +6,12 @@
     </UndefinedClass>
   </file>
   <file src="lib/Controller/ConfigController.php">
-    <DeprecatedMethod>
-      <code><![CDATA[getAppValue]]></code>
-      <code><![CDATA[getAppValue]]></code>
-      <code><![CDATA[setAppValue]]></code>
-    </DeprecatedMethod>
     <InvalidArrayOffset>
       <code><![CDATA[$info['name']]]></code>
       <code><![CDATA[$info['name']]]></code>
     </InvalidArrayOffset>
-    <MixedArgument>
-      <code><![CDATA[$info['name']['display_name']]]></code>
-    </MixedArgument>
-    <MixedAssignment>
-      <code><![CDATA[$data['user_name']]]></code>
-    </MixedAssignment>
-  </file>
-  <file src="lib/Controller/DropboxAPIController.php">
-    <DeprecatedMethod>
-      <code><![CDATA[getAppValue]]></code>
-      <code><![CDATA[getAppValue]]></code>
-    </DeprecatedMethod>
-  </file>
-  <file src="lib/Service/DropboxAPIService.php">
-    <MixedInferredReturnType>
-      <code><![CDATA[array{access_token?: string, refresh_token?: string, account_id?: string, uid?: string, error_description?: string, error?: string, email?: string}]]></code>
-      <code><![CDATA[array{error?:string}]]></code>
-    </MixedInferredReturnType>
-    <MixedReturnStatement>
-      <code><![CDATA[json_decode($body, true)]]></code>
-      <code><![CDATA[json_decode($body, true)]]></code>
-    </MixedReturnStatement>
   </file>
   <file src="lib/Service/DropboxStorageAPIService.php">
-    <DeprecatedMethod>
-      <code><![CDATA[getAppValue]]></code>
-      <code><![CDATA[getAppValue]]></code>
-    </DeprecatedMethod>
     <InvalidArgument>
       <code><![CDATA[$entry]]></code>
     </InvalidArgument>
@@ -53,31 +22,5 @@
       <code><![CDATA[$result['has_more']]]></code>
       <code><![CDATA[$result['used']]]></code>
     </InvalidArrayOffset>
-    <LessSpecificReturnStatement>
-      <code><![CDATA[$result]]></code>
-    </LessSpecificReturnStatement>
-    <MixedAssignment>
-      <code><![CDATA[$entry]]></code>
-    </MixedAssignment>
-    <MoreSpecificReturnType>
-      <code><![CDATA[array{nbDownloaded: int, targetPath: string, finished: bool, totalSeen: int}|array{error: non-empty-string}]]></code>
-    </MoreSpecificReturnType>
-    <PossiblyUndefinedArrayOffset>
-      <code><![CDATA[$result['totalSeen']]]></code>
-    </PossiblyUndefinedArrayOffset>
-    <RiskyTruthyFalsyComparison>
-      <code><![CDATA[$maxDownloadSize]]></code>
-    </RiskyTruthyFalsyComparison>
-  </file>
-  <file src="lib/Settings/Admin.php">
-    <DeprecatedMethod>
-      <code><![CDATA[getAppValue]]></code>
-      <code><![CDATA[getAppValue]]></code>
-    </DeprecatedMethod>
-  </file>
-  <file src="lib/Settings/Personal.php">
-    <DeprecatedMethod>
-      <code><![CDATA[getAppValue]]></code>
-    </DeprecatedMethod>
   </file>
 </files>