Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add transfer endpoint #1173

Merged
merged 14 commits into from
Jul 12, 2024
Merged

feat: Add transfer endpoint #1173

merged 14 commits into from
Jul 12, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 13, 2024

  • Add endpoint for transferring guest to full account

Changes have been split into separate commits for easier reviewing

@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews labels Jun 13, 2024
@Pytal Pytal self-assigned this Jun 13, 2024
lib/Controller/UsersController.php Outdated Show resolved Hide resolved
lib/Controller/UsersController.php Outdated Show resolved Hide resolved
lib/Controller/UsersController.php Outdated Show resolved Hide resolved
lib/Controller/UsersController.php Show resolved Hide resolved
lib/GuestManager.php Outdated Show resolved Hide resolved
@Pytal Pytal force-pushed the feat/transfer-endpoint branch 3 times, most recently from ae0a23e to f252c1a Compare June 21, 2024 19:04
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but still some comments :)

lib/BackgroundJob/TransferJob.php Outdated Show resolved Hide resolved
lib/BackgroundJob/TransferJob.php Outdated Show resolved Hide resolved
lib/BackgroundJob/TransferJob.php Outdated Show resolved Hide resolved
lib/Controller/UsersController.php Outdated Show resolved Hide resolved
lib/TransferService.php Show resolved Hide resolved
lib/TransferService.php Outdated Show resolved Hide resolved
lib/Controller/UsersController.php Show resolved Hide resolved
@Pytal Pytal force-pushed the feat/transfer-endpoint branch 2 times, most recently from c625d10 to 962eab6 Compare June 25, 2024 23:09
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal requested a review from artonge July 12, 2024 00:25
@Pytal Pytal enabled auto-merge July 12, 2024 00:33
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one nitpick

@Pytal Pytal merged commit 51e2a57 into master Jul 12, 2024
38 checks passed
@Pytal Pytal deleted the feat/transfer-endpoint branch July 12, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants