Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop client not syncing changes #597

Closed
hriekehof opened this issue Sep 9, 2019 · 35 comments
Closed

Desktop client not syncing changes #597

hriekehof opened this issue Sep 9, 2019 · 35 comments
Assignees
Labels
1. to develop Issues that are ready for development bug high high priority

Comments

@hriekehof
Copy link

I updated Nextcloud and Groupfolders recently to 16.0.4 and 4.1.0. With GF 4.1.0 the sync of files by the desktop client is only working in some cases. These are the cases i observe.

  1. When i create a file locally it gets synced by the desktop client to the server. But not to other clients automatically.
  2. When i create a file in a groupfolder on the server its not getting synced automatically by any desktop client
  3. Files get synced when i start a manual sync in the desktop client.

I downgrated GF to 4.0.5 and the sync problem is gone. Everything is synced quickly after it is changed in the browser or locally by the desktop app.

There was also a short discussion in #590 but it was bascially another problem.

@patricksebastien
Copy link

I also have this major issue. First I was under the impression that it was the desktop client because I do not have this bug using the Mac client. But it might be related to something else.

Here's the full log and discussion about it:
nextcloud/desktop#1430

I am sending a notification to all my users to use the force sync for now.

@patricksebastien
Copy link

Would it be possible to have a label on this. Surely we are not alone using group folder + desktop client. Downgrading to 4.0.5 is not ideal (I fear this move, I am using group folder with advanced permission).

@wiswedel wiswedel added 0. Needs triage Issues that need to be triaged bug labels Oct 1, 2019
@wiswedel
Copy link
Contributor

wiswedel commented Oct 1, 2019

CC @icewind1991

@hriekehof
Copy link
Author

I also can add that my observation was only with the windows desktop client. I didn't do any test with the mac client.

@gvansanden
Copy link

Sound like my issue indeed but it did work with 4.1.0.
I tested Mac, Windows and Linux clients, versions 2.5.2, 2.5.3 and 2.6.0, I also tested with the OwnCloud client, the issue was present in all versions across platforms

@gvansanden
Copy link

@hriekehof How did you do the downgrade? I think I'll also have to do that

@hriekehof
Copy link
Author

@gvansanden basically the following

  1. Maintenance mode or something which makes your Nextcoud inaccessible by users
  2. Deactivate the current Groupfolder App in Adminarea
  3. Download the Version you want from the Store
  4. Unpack it in the custom_apps folder and overwrite the current version
  5. Active the Groupfolder App in Nextcloud
  6. Go out of Maintenance mode

@gvansanden
Copy link

@hriekehof I did the same steps earlier, but the app still shows as 4.1.3 in the list, do you also have that?

@gvansanden
Copy link

@hriekehof Downgrade worked. But I went to 4.1.0 which was working before. The issue stays...

@gvansanden
Copy link

Downgraded to 4.0.5 and everything started working again... Not fun

@gvansanden
Copy link

I'm going to move away from groupfolders in favor of folders shared by a non-active user. Too many sync issues with them and activities are broken. Nice concept but not worth it.

@derdershat
Copy link

have same problem here... with downgrade to 4.0.5 it is back working.
I use old Windows Client 2.3.3 (because of missing notification in newer versions).

this is a big issue. could this be taken on a higher priority?

@wiswedel
Copy link
Contributor

wiswedel commented Oct 7, 2019

CC @nextcloud/desktop

@hriekehof
Copy link
Author

is this fixed with the new desktop client version 2.6 ?

@gvansanden
Copy link

@hriekehof No, it is server side

@patricksebastien
Copy link

patricksebastien commented Oct 10, 2019

@gvansanden Meaning nextcloud 16.0.4 or the groupfolder plugin? Since it's working for 4.0.5, I think it is safe to say that the bug is in the groupfolder plugin.

@icewind1991 Did you had the time to look at it. Do you have an idea?

@gvansanden
Copy link

@patricksebastien It's a bug in the groupfolder plugin for sure. Not the client or Nextcloud core. Groupfolders and sync are a headache that's not worth it

@TP75
Copy link
Contributor

TP75 commented Oct 10, 2019

NC-Server 16.0.4.1, groupfolders 4.1.3, Debian 10.1, PHP 7.3.9
NC-client version 2.6.0stable (build 20190927), MacOS X / macOS Sierra 10.12.6 & Mojave 10.14.6

I updated Nextcloud and Groupfolders recently to 16.0.4 and 4.1.0. With GF 4.1.0 the sync of files by the desktop client is only working in some cases. These are the cases i observe.

same here

  1. When i create a file locally it gets synced by the desktop client to the server. But not to other clients automatically.

almost same. However, an addendum to (1.) should be:

  • any unknown server content syncs to the client if a new local file gets synced to the resp folder
  • folder content gets synced after the client re-connects & syncs e.g., after WLAN de-activation/re-activation
  1. When i create a file in a groupfolder on the server its not getting synced automatically by any desktop client

same here

  1. Files get synced when i start a manual sync in the desktop client.

same here

  1. A fresh established client account gets a one-time sync if another client syncs. Apparently falls back to (1.) afterwards.

Hope this helps.

@patricksebastien
Copy link

patricksebastien commented Oct 11, 2019

The bug is somewhere between 4.0.5 and 4.1.0:
v4.0.5...v4.1.0
11 .php files changed - I am looking to help as much as I can.

Is this file use for the sync process:
https://github.com/nextcloud/groupfolders/blob/ae0794945b0170fa2ea6f56b7c3931af4a5a800b/lib/Mount/MountProvider.php
getMountsForUser()

Groupfolder is an important app for nextcloud (without it I cannot use nextcloud (advanced permission)). But the desktop client is also very important to my users. I am sure I'm not alone using both.

@gvansanden
Copy link

@patricksebastien I agree, but it causes so many issues. Activities are broken on GF, putting items in trash locks up clients often as they still have a reference to a file they can no longer access. I'm sharing folders from a meta user for now.

@thoro
Copy link

thoro commented Oct 18, 2019

Also affected, is there a work around instead of downgrading the app - which seems to break my instance somehow ..

Has anyone figured out what is happening?

@wiswedel
Copy link
Contributor

Could you please try reproducing once again with

  • Server 16.0.5
  • Group Folder 4.1.3
  • Desktop client 2.6.0

@gvansanden
Copy link

@wiswedel I had the issue on that combination (now rolled back)

@wiswedel
Copy link
Contributor

Alright. Reproduced it now also on

  • Server 16.0.5
  • Group Folders 4.1.3
  • Desktop client 2.6.0 (and 2.6.1 RC1)

and also on

  • Server 17.0.0
  • Group Folders 5.0.3
  • Desktop client 2.6.0 (and 2.6.1 RC1)

Extra info: once any change is made to a normal folder on the server (or another connected client), the group folder sync gets triggered also - but not if changes on the server have been made within a group folder only.

@wiswedel wiswedel removed the 0. Needs triage Issues that need to be triaged label Oct 18, 2019
@wiswedel wiswedel added 1. to develop Issues that are ready for development bug: regression high high priority labels Oct 18, 2019
@rullzer
Copy link
Member

rullzer commented Oct 18, 2019

Sounds like somehow somewhere an etag is not propagated.

@wiswedel wiswedel changed the title Sync with desktop client not working with GF 4.1.0 and Nextcloud 16.0.4 Desktop client not syncing changes Oct 18, 2019
@thoro
Copy link

thoro commented Oct 18, 2019

I have setup a testing instance now, but I have the same issue with 16.0.5 and 4.0.5. Possibly the issue is different from the other guys.

For me the local sync NEVER happens, even if I Force Sync. Only when I uncheck and recheck in the client it will sync.

It's a multiple times nested groupfolder, I assume this might be the issue.

It's 5x nested. With a group folder nested only 3x it works completely fine. (with GF 4.0.5)
And was not working either with the 3x nesting with GF 4.1.3

During testing I only had the relevant folders checked as to be synced

@TP75
Copy link
Contributor

TP75 commented Oct 19, 2019

Have a look at:

Hey,

we've just released 2.6.1 RC1 which is built with Qt 5.12.5 on all platforms (also has OpenSSL 1.1.1d, so it features TLS 1.3).

You may give it a try:
https://github.com/nextcloud/desktop/releases/tag/v2.6.1-rc1

copied from comment NC 2.6.0 client shows an unstable GUI window on Mac OS X after first config
#1501

Maybe the task of improving the RC1+ relates to the above?

@TP75
Copy link
Contributor

TP75 commented Oct 19, 2019

It's a multiple times nested groupfolder, I assume this might be the issue.

@thoro Please clarify the technical nature of "a multiple times nested groupfolder" if possible.

@thoro
Copy link

thoro commented Oct 19, 2019

@TP75 The group folder mountpoints are nested i.e.

each line represents one group folder:

/Level1
/Level1/Level2
/Level1/Level2/Level3
/Level1/Level2/Level3/Level4
/Level1/Level2/Level3/Level4/Level5

Each level contains various different permissions.

With the new permissions features this could be solved easier - once it's stable.

@patricksebastien
Copy link

@thoro Are you using advanced permission?

@thoro
Copy link

thoro commented Oct 19, 2019

@patricksebastien not yet, plain old group folders

@rullzer
Copy link
Member

rullzer commented Oct 21, 2019

So, I think we found it. #647 fixes this. (it causes #648 again but we have to find another way to fix it then).

We'll release a new patch release soon.

@juliusknorr
Copy link
Member

Fix release with 4.1.4 and 5.0.4

@Patrock
Copy link

Patrock commented Nov 23, 2022

on my system i have sync issues with groupfolders , too...

NC-Version: 24.0.5 (and previous 23.X) -> running on docker(Compose)
Group folder version: 12.0.2
Desktopclient Version: 3.6.2 (Windows)

The problem:

  1. create groupfolder for group with User A & B
  2. add files to webui (A)
  3. no sync for user A & B
  4. force sync by client A&B -> files appear
  5. add files to desktop folder for A
  6. files are synced to server but not to User B
  7. wait .. .wait ... wait. ... nothing
  8. force sync on B -> files appear

also on nested groupfolder setups, in one case (our working structure with nested group folders) even a forced synced does not work...

there are no logs to this issue.

What always works: untick folder in client and retick -> everything in sync...

normal syncs (with shared and owned files) are working fine

is there something i could test further ? Someone with similar problems ?

Thx

@TP75
Copy link
Contributor

TP75 commented Dec 14, 2022

on my system i have sync issues with groupfolders , too...

@Patrock - Presumably you should file a new bug report i.e. new issue for this if your a.m. problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Issues that are ready for development bug high high priority
Projects
None yet
Development

No branches or pull requests

10 participants