Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when creating a group folder with the same name as an existing user folder. #18

Closed
radiantwave opened this issue Jun 9, 2017 · 12 comments
Labels
1. to develop Issues that are ready for development bug

Comments

@radiantwave
Copy link

Version: latest master...?

  1. Create folder with content and subfolders
  2. Make the folder to a groupfolder
  3. ???
  4. Content gone!

The content of the folder should be moved into the "created" groupfolder.

@jospoortvliet
Copy link
Member

How did you do step 2? Or is this a feature request, that an admin can turn a folder into a group folder?

@jospoortvliet
Copy link
Member

There's a weird overlap with existing folders. Take this scenario:

  • Go to the Files app and create a folder named superawesometest
  • Put a few files in it.
  • Go to the Group Folders admin and create a folder named superawesometest
  • Add the Admin group to the access rights for superawesometest
  • Go back to Files and observe the new Group Folder has overwritten the existing superawesometest and it is empty. Where are my files?!!?!
  • Go to the Group Folders admin and remove Admin group access to the folder superawesometest
  • Go back to Files and observe the new Group Folder has disappeared and the existing superawesometest is back with its original content!
  • Note that this overwriting of existing folders with (empty) Group Folders also happens with users - if you create a group folder with the same name as a folder one of your users has, they will lose access to that folder and all its content.

I think Group Folders should act like shares - if somebody shares a folder with the same name as an existing one with you, it should show up besides the existing one, not overwrite it.

@heldchen
Copy link

ran into this issue as well, but had an additional side effect of ending up with multiple shared folderswith the same name

  1. create normal folder, share with group
  2. create group folder with same name
  • users now see two shared folders
  • deleting the Shared Folder results in an error, share not removed
  • deleting the Group Folder removes all content but restores the Shared Folder

the workaround for the duplicated shares is to first save the folder contents, remove the Group Folder, then remove the Shared Folder, then recreate the Group Folder.

@icewind1991
Copy link
Member

the problem with trying to do any kind of conflict resolution on creating group folders (whether it is moving the files into the group folder, or even just showing a warning), is that it would have to check for conflicts for every user that has the folder which is much to expensive to do on large instances.

@marianoju
Copy link

marianoju commented Jul 11, 2018

+1
I ran into the same problem here.

@ghost
Copy link

ghost commented Oct 13, 2018

the problem with trying to do any kind of conflict resolution on creating group folders (whether it is moving the files into the group folder, or even just showing a warning), is that it would have to check for conflicts for every user that has the folder which is much to expensive to do on large instances.

This means, that the app has some kind of structural, fundamental issue. IMHO it is not really acceptable to publish this as a "featured" app in the Nextcloud App Store with so many open problems. This app seems to be more like in beta status and not ready for use in production.

@wiswedel
Copy link
Contributor

Fixed by #523

@kesselb
Copy link
Contributor

kesselb commented Nov 22, 2019

@wiswedel should we reopen? #523 has been reverted.

@wiswedel
Copy link
Contributor

@wiswedel should we reopen? #523 has been reverted.

totally I guess :-(

@wiswedel wiswedel reopened this Nov 22, 2019
@wiswedel
Copy link
Contributor

ref: #647

@pierreozoux pierreozoux changed the title Creating Groupfolder from folder with content Unexpected behavior when creating a group folder with the same name as an existing user folder. Mar 13, 2021
@pierreozoux pierreozoux added the 1. to develop Issues that are ready for development label Mar 13, 2021
@fschrempf
Copy link
Contributor

As far as I can see this is also covered by #648 and others and it should be finally fixed now by #1239.

@mkaag
Copy link

mkaag commented Aug 20, 2024

Same issue with v29.0.4.1 : rename an existing "group folder" after the name of an existing fodler shared by individual account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Issues that are ready for development bug
Projects
None yet
Development

No branches or pull requests

10 participants