Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving a subfolder from a groupfolder cause duplicate files and other issues #128

Closed
fabrixxm opened this issue Jun 20, 2018 · 10 comments
Closed
Labels

Comments

@fabrixxm
Copy link

I have a groupfolder, named "Group", I create a new subfolder, "test".
There I upload 2 files, "image.jpeg" and "document.docx"

I move the folder "test" out of "Group", in user's root, either by drag-n-drop or by selecting the folder and using the "copy / move" dialog.

I enter in "test" folder now and (after a few reload, some cache mabe?) I see this:
schermata 2018-06-20 alle 15 13 40

And opening document.docx (with Collabora) I get this in logs:

Level App Message
Error PHP fopen(/var/www/nextcloud/data/__groupfolders/10/test/document.docx): failed to open stream: No such file or directory at /var/www/nextcloud/lib/private/Files/Storage/Local.php#282

Netcloud 13.0.4
Group folders 1.2.0

@Cracky5457
Copy link

Cracky5457 commented Jul 11, 2018

I just tested this bug and I was able to reproduce it. If you move a SubGroupFolder into the hierarchy of the group folder but not the root it's ok. If you move a subgroup to the root group folder it's corrupted ( for the odt file ) and if you remove the folder the image appears twice. Also if you move the subfolder outside the group folder ( so not the group folder parent but the real root of your nextcloud space ) it's the same issue.

Exemple :

I have the group folder

Parent/Child1/Child2/Child3

You can move Child3 into Child1 or Child2 but not in Parent ( you can but it will result in corrupted files )

Also you can move Child3 outside of Parent ( directly in the root ) and it's corrupted too.

Also, if you try to remove the .jpg which appears twice, after the odt file appears twice, and if you delete one of these 2 file and try to open the one which remain you got a nextcloud internal error. And the .jpg is never deleted, if you refresh your folder it's still here.

@icewind1991
Copy link
Member

I can't reproduce this locally

@Cracky5457
Copy link

Cracky5457 commented Jul 13, 2018

I reproduce it on my dev hosted instance. But also locally with my dev environement with nextcloud 13.0.4 and the latest version of group folder.

It's really simple to reproduce.

  • You create a groupfolder "Test : /Test
  • Then you create some subfolder into through the UI : /Test/Child1/Child2/Child3
  • In Child3 you put a .jpeg file and a doc/excel file ( or better your create a collaborative doc file with the collabora pugin )
  • Then through the UI ( using the breadcrumb ) you move child3 on the root / ( So outside the group folder /Test, in your personal root space
  • Then you move back child3 into your group folder, you can move in severals times
  • Try to repetively open/close your jpeg / move your folder inside the group folder ( at some points you can t move it )
  • Then look inside your folder

bug1

bug2

bug3

bug4

at this point you can't move or delete your folder, everthing is corrupted, sometimes you can delete it and you refresh and it still appears and you get an internal error if you open it.

@sunchezz89
Copy link

I would like to let you know, I had a similar issue, when moving the Group folder from User root, into another folder in user's root.

After this, things break.
Is it enough to reference, or should I open a new one?
nextcloud/server#10366

@Cracky5457
Copy link

Cracky5457 commented Jul 26, 2018

icewind1991 please investigate on this. I know it's probably an issue difficult to solve, maybe which have to be solve on nextcloud platform core. But it made groupfolder almost unusable for a serious company.

Maybe if we choose nextcloud we will personally investigate on this when the times come, but for now we are not sure about using nextcloud for a big project because of this kind of bugs.

@basemod
Copy link

basemod commented Aug 23, 2018

Hi, thank you for this Module.
I have the same issue here, using NC 13.0.4 and Group Folders 1.3.3

@lievenmoors
Copy link

Same issue here, but still running on NC 13.

Example of what happens here:

  • move a folder test containing to files test1 and test2 from one groupfolder to another
  • the files appear correctly in the new location
  • but in the filecache, there are still remnants for test/test1 and test/test2 under the OLD location, but the parent of those files is the folder "test" in the NEW location. So basically, these files don't have a valid parent anymore.
  • the result is that you see the files twice in the Nextcloud web interface. When you try to click on them, the interface refreshes without opening the files.
  • the only solution is to delete these remnants from the file cache

@fschrempf
Copy link
Contributor

Using NC 21.0.0 and groupfolders 9.0.0 I can't reproduce this issue. Is this still a problem somewhere?

@pierreozoux
Copy link
Member

I'll close then, feel free to reopen.

@fabrixxm
Copy link
Author

I'm on NC 20.0.8 with groupfolder 8.2.0 and looks like it is working correctly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants