-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
Add livephotos support from Apple : - Create a new container in slideshow view - Authorize loading data from "blob:" in content security policy - Retrieve NPM version of livephotoskit.js To work, a .jpg/.JPG picture needs to have beside a .mov/.MOV video with the same name Signed-off-by: François Sylvestre <francoissylv@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=========================================
Coverage ? 82.62%
Complexity ? 360
=========================================
Files ? 38
Lines ? 1324
Branches ? 0
=========================================
Hits ? 1094
Misses ? 230
Partials ? 0
Continue to review full report at Codecov.
|
Thanks a lot for your contribution @fefux! 🎉 And sorry for the late reply. Could someone with macOS or iPhone look into this? @nextcloud/mac 🍏 |
I just noticed that my pullrequest breaks the default slideshow in nextcloud. So I'm fixing the bug and I will update the PR. |
@fefux thanks, esp given we're close to the 14 release 🥇 - I think we should try to get this in if we still can... If not, 15 🥈 |
Just before going in vacation, I tested a functional patch. The issue is the default slideshow is override by the one in gallery but additional dependencies for livephoto not. |
Default slideshow (outside gallery) doesn't handle livePhotos. A fake livePreview permits to handle this issue. Signed-off-by: François Sylvestre <francoissylv@gmail.com>
Add a map of mathcing extensions Clean code for translate image file name to video file name Signed-off-by: François Sylvestre <francoissylv@gmail.com>
Remove useless conditional test Add or fix some comments Signed-off-by: François Sylvestre <francoissylv@gmail.com>
@fefux Even if this is a super nice feature, time runs up and we need to move this to Nextcloud 15, which is planned for December. I hope this is okay for you? |
No problem for me, in addition this functionnality is eventually more usefull if nextcloud app for iphone supports importation of live photo too (which seems not be the case now). |
I saw that ios live photos support was removed from the Nextcloud 15 milestone. Will still be developed? |
Fix code to work with latest nextcloud release Signed-off-by: François Sylvestre <francoissylv@gmail.com>
Fix code to for next nextcloud version Signed-off-by: François Sylvestre <francoissylv@gmail.com>
Hi everybody, sorry for the late, I just updated the code for support livephoto for nextcloud 15.0.4 and with the tip of the branch. @AndreiButoi development still on going. |
Delete signature.json file which should not tracked
Signed-off-by: François Sylvestre francoissylv@gmail.com
Signed-off-by: François Sylvestre francoissylv@gmail.com
@fefux do you need some help on this? I'd be willing to work on this issue as I need it myself :) |
Joe do you extract those two files from an iPhone? We tried to extract this, but it always just exported the jpeg file without the mov. Also @skjnldsv is working on bringing this to the viewer (see repo at nextcloud/viewer repo) |
Something new here ? |
This is already in the new viewer :) |
https://github.com/nextcloud/viewer <- this unifies the different viewers of gallery, text editor, PDF, etc and replaces the slideshow from the gallery app. |
Is it already released in NC 16? I doesn't work for me. When I use the viewer in a folder which contains IMG_4112.JPG and IMG_4112.MOV one is shown as picture, the other as video. What is the expected behaviour? |
@k1l1 nc 17 |
@skjnldsv will this actually be in Nextcloud 17? It looks like it will wait for NC18 at the very least, doesn’t it? |
We now ship a new viewer since 16. Not the gallery, on files. It now sypport livephotos that are split into jpg/video in the same dir :) |
Okay so just to make sure I'm getting it right: let's consider I upload a Live Photo from my iPhone automatically using Nextcloud's app. A new folder with the photo + video of the Live Photo is created in my /Photo folder. If I browse to said folder using my instance's file explorer, the file viewer will display it as a Live Photo. If I browse my Gallery, I will see a photo and a video. Is this right?
It may not belong here, but still has some ties with the gallery I think: if I upload a Live Photo from my phone to the Gallery, wipe the phone, and download back what was uploaded to my instance, will I have a Live Photo or a photo+video on my phone? Thanks for your answers and work @skjnldsv, it's really helpful :) |
I cannot tell. This is something to check with your phone :)
Right! :) |
Crystal clear, thanks! All this leads me to think that gallery is going to be either deprecated or deeply changed. Is this the case? |
Yes :) |
So if I understand this right, the requirement for this to work is a jpg/mov combo, is there any chance it would also work with a HEIC/mov combo, files of the same name? or any wip for it? Thanks for all the good work. |
Not only, any image/video combo is fine :)
We just need to support heic then, but that's a tricky part since heic can contains lots of stuff: multiple images, videos... |
Hello, |
The gallery app has been replaced by the beautiful new app: Please checkout if your Pull request is still necessary there, and in case create it there or raise an issue for others to copy the change from here. |
Add livephotos support from Apple :
To work, a .jpg/.JPG picture needs to have beside a .mov/.MOV video with the same name
Signed-off-by: François Sylvestre francoissylv@gmail.com