feat: Add forms state to close and archive forms

[susnux]

• Resolves Archive forms #1834
• Resolves Deactivate Form manually #1101

I recommend to hide white space when review.

This adds a new field "state" to a form, this field is 0 by default which means the form is in active state.
Currently two other states are implemented:

• closed when then form was manually closed
• archived when the form was archived

Closed forms do not allow any new submissions, archived forms even do not allow any modification.
Archived forms are shown in a separate list on the side bar to save space.

Screenshots

open list	closed list

[susnux]

Rebased, squashed and fixed the tests. Ready for review :)

[susnux]

We should ask the designers about their opinion. IIRC Jan didn't want to have the archived forms in the App Navigation but in a modal...

I have added screenshots and requested a review from @jancborchardt :)

[jancborchardt]

Yeah, "Archived forms" would be better as a sticky entry on the bottom left which opens a modal, just like in Contacts and Calendar.

[susnux]

Yeah, "Archived forms" would be better as a sticky entry on the bottom left which opens a modal, just like in Contacts and Calendar.

Thank you @jancborchardt !
I now changed it to show the archived forms in a dialog / modal instead:

vokoscreenNG-2024-02-19_21-36-15.mp4

[susnux]

Yes I understand that and agree that after a while they will be less important. But for that one can archive the form. So I'd be happier without this grouping :)

Done

[Chartman123]

Looks good now :)

Just some design/UX related things: Should we make it possible to dearchive a form directly from the modal? And on a public share page you always show the "expired" message in the NcEmptyContent as the FormsService always returns isExpired as soon as the state is not "active". So no hint for archived/closed there...

[Chartman123]

One more comment: the state is not imported in FormsMigrator.php. The linked file related props are also missing, but I'm not sure if they really make sense when you import a Form in another instance. The state however could make sense, so I think we should add it there.

[Chartman123]

Please integrate the fix for #1991 into this PR. Should be easy to fix and you can directly address the new state prop as well :)

[jancborchardt]

Sorry for the late design feedback, 3 things:

• The layout of the left navigation is a bit off, lot of whitespace (e.g. below the "Your forms" heading) and the entries are too big. Since there is no subline, they should be single-line entries like in Files or the left navigation of Mail, not multiline list items like in Talk or the message list in Mail.
• The "Archived forms" entry on the bottom does not have proper spacing to the bottom. Check how "Files settings" does it – left aligned, tertiary button, non-bold text.
• In the modal, the actions button should show for all entries by default, not only on hover or focus → this is better for discoverability

[Chartman123]

• The layout of the left navigation is a bit off, lot of whitespace (e.g. below the "Your forms" heading) and the entries are too big. Since there is no subline, they should be single-line entries like in Files or the left navigation of Mail, not multiline list items like in Talk or the message list in Mail.

This is only true for forms without expiration date. Then the expiration is shown in the subline. Also closed forms show the information in the subline. So no changes needed here :)

[susnux]

Thank you for the feedback, I resolved the comments :)

a.mp4

[susnux]

@Chartman123 changes make sense, one comment.

But I think we need a follow up some when, because always loading all forms is pretty bad. For small instances this works but what if there are 30'000 forms? 100'000?

design was adjusted

[susnux]

Should be ready to merge now