fix mutating prop directly by removing loading spinner #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
|
/backport to stable3 |
backportbot-nextcloud
bot
added
the
backport-request
|
I would say for feedback we should keep the loading spinners. |
|
I found no other place where these spinners are currently used. Also nothing in other apps... |
|
I know the users list in server does use it. Generally somekind of feedback would be nice for UX so you know at least something is happening. |
|
Strange, but I can't reproduce the warnings any more... Neither in NC27 nor in NC28. So I'm going to close this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Hartmann chris-hartmann@gmx.de