Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(sharing): Move away from deprecated icon classes and allow to search user by email #1802

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Nov 28, 2023

  1. Move away from deprecated css classes for icons and use SVGs
  2. Add subname attribute to sharees, this allows to search users by their email address like on server core

Resolves #1781

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Nov 28, 2023
@susnux susnux added this to the 4.0 milestone Nov 28, 2023
Copy link
Collaborator

@Chartman123 Chartman123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

…rch user by email

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@Chartman123 Chartman123 merged commit 5a1f047 into main Nov 28, 2023
34 checks passed
@Chartman123 Chartman123 deleted the enh/improve-sharing branch November 28, 2023 23:28
@susnux
Copy link
Collaborator Author

susnux commented Nov 28, 2023

/backport to stable3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: 👥 sharing settings javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search for users by email in the sharing section
2 participants