fixup! Save a Single Question as csv

Signed-off-by: hamza mahjoubi <hamzamahjoubi221@gmail.com>
nextcloud · Dec 9, 2023 · 0917573 · 0917573
1 parent f465264
commit 0917573
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/appinfo/routes.php b/appinfo/routes.php
@@ -296,15 +296,15 @@
 			'url' => '/api/{apiVersion}/submissions/exportQuestion/{questionId}',
 			'verb' => 'GET',
 			'requirements' => [
-				'apiVersion' => 'v2'
+				'apiVersion' => 'v2.2'
 			]
 		],
 		[
 			'name' => 'api#exportSubmission',
 			'url' => '/api/{apiVersion}/submissions/exportSubmission/{submissionId}',
 			'verb' => 'GET',
 			'requirements' => [
-				'apiVersion' => 'v2'
+				'apiVersion' => 'v2.2'
 			]
 		],
 		[

diff --git a/lib/Controller/ApiController.php b/lib/Controller/ApiController.php
@@ -1121,8 +1121,8 @@ public function exportQuestion(int $questionId): DataDownloadResponse {
 			throw new OCSBadRequestException();
 		}
 
-		if ($form->getOwnerId() !== $this->currentUser->getUID()) {
-			$this->logger->debug('This form is not owned by the current user');
+		if (!$this->formsService->canSeeResults($form)) {
+			$this->logger->debug('The current user has no permission to get the results for this form');
 			throw new OCSForbiddenException();
 		}
 
@@ -1154,7 +1154,7 @@ public function exportSubmission(int $submissionId): DataDownloadResponse {
 			throw new OCSBadRequestException();
 		}
 
-		if (!$this->formsService->canSeeResults($form->id)) {
+		if (!$this->formsService->canSeeResults($form)) {
 			$this->logger->debug('The current user has no permission to get the results for this form');
 			throw new OCSForbiddenException();
 		}

diff --git a/src/components/Results/ResultsSummary.vue b/src/components/Results/ResultsSummary.vue
@@ -199,7 +199,7 @@ export default {
 			return textAnswers
 		},
 		questionDownload() {
-			return generateOcsUrl('apps/forms/api/v2/submissions/exportQuestion/{questionId}', { questionId: this.question.id })
+			return generateOcsUrl('apps/forms/api/v2.2/submissions/exportQuestion/{questionId}', { questionId: this.question.id })
 		},
 	},
 }

diff --git a/src/components/Results/Submission.vue b/src/components/Results/Submission.vue
@@ -92,7 +92,7 @@ export default {
 
 	computed: {
 		responseDownload() {
-			return generateOcsUrl('apps/forms/api/v2/submissions/exportSubmission/{submissionId}', { submissionId: this.submission.id })
+			return generateOcsUrl('apps/forms/api/v2.2/submissions/exportSubmission/{submissionId}', { submissionId: this.submission.id })
 		},
 
 		// Format submission-timestamp to DateTime

diff --git a/src/views/Results.vue b/src/views/Results.vue
@@ -168,7 +168,6 @@ import PermissionTypes from '../mixins/PermissionTypes.js'
 
 const picker = getFilePickerBuilder(t('forms', 'Save CSV to Files'))
 	.setMultiSelect(false)
-	.setModal(true)
 	.setType(1)
 	.allowDirectories()
 	.build()