-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overlapping buttons #651
Conversation
5ffff2c
to
b7f3bd0
Compare
/compile amend / |
/backport to stable23 |
/backport to stable22 |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
b7f3bd0
to
21c21a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fod of the migration of the primary button to the left. I would have maybe made the main content scrollable/shrinkable and the button fixed at the bottom 🤔
Just pushed a new commit that switches the sides which is a good solution as well, imo. Please have a look at the updated screenshots :) |
/compile amend / |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
afd8ebf
to
cd88070
Compare
/backport to stable21 |
This is best reviewed like this: https://github.com/nextcloud/firstrunwizard/pull/651/files?diff=unified&w=1
Desktop
Mobile
Signed-off-by: szaimen szaimen@e.mail.de
For my own testing