Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Ignore query arguments in single video share for stable15 (Fix #121) #122

Conversation

MathieuDebit
Copy link

@MathieuDebit MathieuDebit commented Mar 17, 2019

Same fix as commit 4da10ee but for stable15. See #121.

I'm not sure to know how to contribute here so tell me if it's good 🙏

Same fix as commit 4da10ee for stable15

Signed-off-by: Mathieu Débit <mathieu+github@debit.email>
@MathieuDebit MathieuDebit force-pushed the stable15-fix-ignore-query-arguments-video branch from b214f85 to 27dfbd3 Compare March 17, 2019 16:47
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Looks good except for the version bump.

appinfo/info.xml Outdated
@@ -10,7 +10,7 @@

Skin: https://github.com/cabin/videojs-sublime-skin
</description>
<version>1.4.0</version>
<version>1.4.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump the version in this PR.

Signed-off-by: Mathieu Débit <mathieu+github@debit.email>
@MathieuDebit MathieuDebit force-pushed the stable15-fix-ignore-query-arguments-video branch from 05a2490 to b473b04 Compare March 20, 2019 16:09
@MathieuDebit
Copy link
Author

@juliushaertl I updated the PR 👌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants