Video doesn't scale in fullscreen (public video share)

[jonassvatos]

Expected behaviour

In fullscreen mode, video scales across the whole display.

Actual behaviour

Video doesn't scale, screen is filled with black around the video content instead.

Steps to reproduce

1. Click the fullscreen icon
2. Observe the error
3. cry

Nextcloud 15.0.0
Video player 1.4.0
Error is present in latest Chrome, latest FF, IE 11. Windows and Linux (OSX wasn't tested)
Other players based on video.js behave as expected.
screenshot : https://i.imgur.com/I7nxHDZ.png

[Instagit]

I can't reproduce this. Is there an error message in the browser console?

1. open browser development tools (CTRL+SHIFT+I)
2. go to console tab

Also, please try to reload the page without browser cache. Should happen on its own when you have the dev tools open.

[jonassvatos]

Thanks, DevTools unfortunately don't affect the behaviour, neither FF, Chome, regardless on the OS.
This happens to all the users on our instance, including external users, which count into hundreds.

Here is a live example:
https://transfer.digilab.nfa.cz/s/3BYJJybebtegQNd

[Instagit]

I see, so it only happens on the public share page. That's a good info and I see it now. The custom video player was only added to that page in the last few updates, so there must be an error somewhere. Probably CSS that doesn't work, because the whole structure of that page is different. We'll look into it.

[jonassvatos]

Allright, Thanks!
Sorry, originally I should've clarified that it happens only on public share link..

[Instagit]

No worries, thanks for reporting it. :)

@juliushaertl I don't know when I got time to look at this. Maybe you can find the problem faster since you did the implementation on the public share page (731a2ef - 21fc17b).

Part of the problem is with this CSS:

#imgframe .video-js .vjs-tech {
    position: relative;
    width: auto;
    height: auto;
}

When you remove it, the video is fine in fullscreen, but the normal player is not visible.

video.js also throws an exception on the public video page.

[juliusknorr]

@Instagit I'll have a look.

[pjrobertson]

I've proposed some changes that fix this.

[jonassvatos]

Tested, LGTM

[ChildLearningClub]

I'm not sure if something got added that broke this again, but there are a few issues with shared link video in fullscreen on ios mobile. using Safari and other browsers gives same result.

• vertical video when hitting the full screen arrows in bottom right corner gives this result.

• Swiping to next video overlays previous video without closing it.

and sometimes hitting the full screen arrows just goes to the next video/image and doesn't function at all.

[drequivalent]

Please reopen the issue! I'm experiencing this on a fresh Nextcloud install

[juliusknorr]

The files video player is now part of https://github.com/nextcloud/viewer so please open a new issue over there.