Poisiton clock more centered in app logo fixes #11 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested changes
Jan 19, 2017
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <svg width="16" height="16" viewBox="0 0 16 16" version="1.1" xmlns="http://www.w3.org/2000/svg"> | |||
| <path d="M13,5L12.125,14C12.064,14.549 11.552,15 11,15L5,15C4.448,15 3.936,14.549 3.875,14L3,5L13,5ZM8,6.02C6.096,6.02 4.543,7.573 4.543,9.477C4.543,11.381 6.096,12.934 8,12.934C9.904,12.934 11.457,11.381 11.457,9.477C11.457,7.573 9.904,6.02 8,6.02ZM8,6.885C9.437,6.885 10.593,8.04 10.593,9.477C10.593,10.914 9.437,12.07 8,12.07C6.563,12.07 5.407,10.914 5.407,9.477C5.407,8.04 6.563,6.885 8,6.885ZM7.809,7.287C7.665,7.29 7.549,7.408 7.549,7.552L7.181,9.471L7.181,9.476C7.102,9.803 7.326,9.909 7.576,10.061L7.579,10.062L8.874,10.744C9.156,10.961 9.482,10.538 9.2,10.321L8.432,9.481L8.432,9.477L8.083,7.555C8.083,7.404 7.96,7.283 7.809,7.287L7.809,7.287ZM9.5,1L10,2L13,2C13.554,2 14,2.446 14,3L14,4L2,4L2,3C2,2.448 2.443,2.003 3,2L6,2L6.5,1L9.5,1Z" style="fill:#fff;"/> | |||
| <svg viewBox="0 0 16 16" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xml:space="preserve"> | |||
There was a problem hiding this comment.
viewbox needs to match the actual size of the image, I think it's 128 now?
There was a problem hiding this comment.
You mean as a standard for nextcloud or generally. Because I am pretty sure this is only, so the coordinates make sense (they are all between 0 and 16). The width I exported was 16x16.
There was a problem hiding this comment.
Okay actually looks fine, I was confused, because the diff on github was so huge.
nickvergessen
approved these changes
Jan 19, 2017
Signed-off-by: Felix A. Epp <work@felixepp.de>
eppfel
force-pushed
the
logo-position-fix
branch
from
6faec89
to
8fa6072
Compare
MorrisJobke
approved these changes
Jan 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved it just a little bit. It is still 100% the middle of the bin, but visually more pleasing.