Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Fix extraction of PDF.js package #807

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[stable27] Fix extraction of PDF.js package #807

merged 2 commits into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. Fix extraction of PDF.js package 

    It seems that in some cases "unzipper" may not extract all the files
and, with some node versions, it may corrupt some of the extracted
files. As there is no fix for all that yet (downgrading "unzipper" to
0.10.11 might solve the missing extracted files, but it would still be
affected by the corrupted files and thus prevent upgrading to a newer
node version) "unzipper" was replaced by "adm-zip".

"adm-zip" does not have dependencies and has a large user base.
Unfortunately it does not support streams and requires loading the whole
file in memory to be able to extract it, but the package is not very
large (around 5,5 MiB), so this should not be a problem.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d638a6f View commit details
    Browse the repository at this point in the history

  2. Add back files deleted due to broken extraction of PDF.js 

    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3032110 View commit details
    Browse the repository at this point in the history