Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Fix npm audit #767

Merged
merged 2 commits into from
Jul 12, 2023
Merged

[master] Fix npm audit #767

merged 2 commits into from
Jul 12, 2023

Conversation

nextcloud-command
Copy link
Contributor

Auto-generated fix of npm audit

@nextcloud-command nextcloud-command added 3. to review dependencies Pull requests that update a dependency file labels Jun 25, 2023
@nextcloud-command nextcloud-command force-pushed the automated/noid/master-fix-npm-audit branch from c0ceee2 to b0fb7ff Compare July 2, 2023 03:28
@nextcloud-command nextcloud-command force-pushed the automated/noid/master-fix-npm-audit branch from b0fb7ff to 973eaa7 Compare July 9, 2023 03:54
@szaimen szaimen added this to the Nextcloud 28 milestone Jul 10, 2023
@nextcloud-command
chore(deps): fix npm audit
1607ded 
Signed-off-by: GitHub <noreply@github.com>
@nextcloud-command nextcloud-command force-pushed the automated/noid/master-fix-npm-audit branch from 973eaa7 to 1607ded Compare July 10, 2023 14:19
@szaimen szaimen requested a review from danxuliu July 10, 2023 14:20
@szaimen
Copy link
Collaborator

szaimen commented Jul 11, 2023

/compile amend /

1 similar comment
@szaimen
Copy link
Collaborator

szaimen commented Jul 11, 2023

/compile amend /

@szaimen
Copy link
Collaborator

szaimen commented Jul 11, 2023

/compile

@nextcloud-command
chore(assets): Recompile assets
ecb4a53 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
szaimen
szaimen approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

danxuliu
danxuliu reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI is broken. However, this seems to be unrelated and to have been caused by #762, as rebuilding with node 16 fixes the UI. Therefore, I would merge as is and leave the UI fix for a later pull request.

@szaimen szaimen merged commit 3b8e4c1 into master Jul 12, 2023
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the automated/noid/master-fix-npm-audit branch July 12, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu left review comments

@szaimen szaimen szaimen approved these changes

Assignees
No one assigned
Labels
4. to release dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@nextcloud-command @szaimen @danxuliu