Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/viewer #195

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Enh/viewer #195

merged 3 commits into from
Aug 13, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 13, 2020 •
edited
Loading

  • Created webpack config
  • Removed shipped vendors
  • Added automated pdf.js release download
  • Bumped pdf.js to latest 2.4.456
  • Updated Makefile
  • Eslint/Stylelint/PhpCS
  • Cleanup
  • Github actions
  • Public single shares pages

fix #193

@skjnldsv skjnldsv self-assigned this Aug 13, 2020
@skjnldsv skjnldsv added this to the Nextcloud 20 milestone Aug 13, 2020
@skjnldsv skjnldsv marked this pull request as ready for review August 13, 2020 13:29
MorrisJobke
MorrisJobke approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so far 🐘

@skjnldsv
Move packaging to webpack and update/clean all configs
7b2198f 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Public pages
6954a8d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Public pages
c775e15 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

Public patch pushed too! Ready to go! 🚀

@skjnldsv skjnldsv merged commit 3f71961 into master Aug 13, 2020
@skjnldsv skjnldsv deleted the enh/viewer branch August 13, 2020 14:24
@danxuliu danxuliu mentioned this pull request Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@danxuliu danxuliu Awaiting requested review from danxuliu danxuliu is a code owner

Assignees

@skjnldsv skjnldsv

Labels
3. to review enhancement high
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.

Update pdf.js for Linear PDF feature
3 participants
@skjnldsv @MorrisJobke @juliusknorr