Re: [nextcloud/files_pdfviewer] Last Page of PDF cut off on Android Mobile (Issue #660)

[orangkucing]

PDFView.vue is patched to set vertical size correctly.

[danxuliu]

Thanks for your contribution!

I still need to take a deeper look to the fix, but from a quick test it looks promising :-)

However, some changes would be needed before merging it. Right now:

• as the two commits are interrelated they should be squashed into a single one
• the commit message should be adjusted to be descriptive of the change
• the unneeded code should be removed rather than commented
• the existing rule for height should be modified rather than overriden with an additional one.

Also please note that further changes might be needed (or not) once I do a deeper review (which might take a while, sorry about that).

Would you like to do those changes yourself, or would you prefer me to take over and do them?

Thanks!

[orangkucing]

I prefer you to take over and do them. Thanks.