[stable14] Hide footer in public share page #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The footer in the public share page is hidden by adding the "hidden" CSS class to the footer. However, the CSS rules for the footer defined in the server are more specific than the general rule for ".hidden" elements, which caused the footer to be shown even if marked as ".hidden". Now a more specific rule was added to override the ones from the server and ensure that the footer is hidden. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
Tested and works 👍 |
|
CSS only -> merge |
This was referenced Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #99