Can't open PDF when filename or folder name contains a space or special character (' ', é, ...) #381

maxrekorder · 2021-05-15T10:19:50Z

🩹 Temporary fix (will be shipped in the next Nextcloud minor release only)

ℹ️ This is a temporary fix you can apply manually, from PR #384. To do this:

1) Replace the file at `apps/files_pdfviewer/js/files_pdfviewer-main.js` on your instance with this file from that PR

2) Clear your (each user must do it) browser's cache and try to open pdfs. This is a must-do, otherwise, the old file will be loaded from browser's cache !!

Steps to reproduce

Create a New Folder
Add a PDF file to to the folder. PDF filename containing a space (e.g. name it "Juergen Klopp.pdf").
Open PDF file "Juergen Klopp.pdf"
It also won't work if the folder contains a space

Expected behaviour

Open the PDF with PDF viewer

Actual behaviour

PDF.js Version 2.5.207 (build: 0974d6052)
Nachricht: Missing PDF "https://domain.org/remote.php/dav/files/user/New/Juergen%2520Klopp.pdf".

Server configuration detail

Operating system: Linux 5.4.0-65-generic #73-Ubuntu SMP Mon Jan 18 17:25:17 UTC 2021 x86_64

Webserver: Apache/2.4.41 (Ubuntu) (apache2handler)

Database: mysql 8.0.25

PHP version:

8.0.5
Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, json, Reflection, SPL, session, standard, sodium, apache2handler, mysqlnd, PDO, xml, apcu, bcmath, calendar, ctype, curl, dom, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, igbinary, imagick, intl, ldap, exif, mysqli, pdo_mysql, Phar, posix, readline, redis, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, xmlreader, xmlwriter, xsl, zip, Zend OPcache

Nextcloud version: 21.0.2 RC1 - 21.0.2.0

Updated from an older Nextcloud/ownCloud or fresh install:

Where did you install Nextcloud from: unknown

Signing status

Array
(
)

List of activated apps

Enabled:
 - accessibility: 1.7.0
 - apporder: 0.12.0
 - calendar: 2.2.1
 - circles: 0.21.2
 - cloud_federation_api: 1.4.0
 - comments: 1.11.0
 - contacts: 3.5.1
 - contactsinteraction: 1.2.0
 - dav: 1.17.1
 - documentserver_community: 0.1.9
 - federatedfilesharing: 1.11.0
 - federation: 1.11.0
 - files: 1.16.0
 - files_external: 1.12.0
 - files_pdfviewer: 2.1.0
 - files_rightclick: 1.0.0
 - files_sharing: 1.13.1
 - files_trashbin: 1.11.0
 - files_versions: 1.14.0
 - files_videoplayer: 1.10.0
 - firstrunwizard: 2.10.0
 - forms: 2.2.4
 - issuetemplate: 0.7.0
 - logreader: 2.6.0
 - lookup_server_connector: 1.9.0
 - notes: 4.0.4
 - notifications: 2.9.0
 - oauth2: 1.9.0
 - onlyoffice: 7.0.2
 - passman: 2.3.7
 - password_policy: 1.11.0
 - photos: 1.3.0
 - privacy: 1.5.0
 - provisioning_api: 1.11.0
 - recommendations: 1.0.0
 - serverinfo: 1.11.0
 - settings: 1.3.0
 - sharebymail: 1.11.0
 - support: 1.4.0
 - survey_client: 1.9.0
 - systemtags: 1.11.0
 - tasks: 0.13.6
 - text: 3.2.0
 - theming: 1.12.0
 - theming_customcss: 1.8.0
 - twofactor_backupcodes: 1.10.0
 - updatenotification: 1.11.0
 - user_status: 1.1.1
 - viewer: 1.5.0
 - weather_status: 1.1.0
 - workflowengine: 2.3.0
Disabled:
 - activity
 - admin_audit
 - bruteforcesettings
 - dashboard
 - encryption
 - mail
 - nextcloud_announcements
 - user_ldap
 - workflow_pdf_converter

Configuration (config/config.php)

{
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "cloud.rekorder.org"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "dbtype": "mysql",
    "version": "21.0.2.0",
    "overwrite.cli.url": "http:\/\/cloud.rekorder.org",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "updater.release.channel": "stable",
    "memcache.local": "\\OC\\Memcache\\APCu",
    "maintenance": false,
    "data-fingerprint": "11bd4c43db46260d550ca15af9437513",
    "mail_smtpmode": "smtp",
    "mail_smtpsecure": "ssl",
    "mail_sendmailmode": "smtp",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpauthtype": "LOGIN",
    "mail_smtpauth": 1,
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpport": "465",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "theme": "",
    "loglevel": 2,
    "app_install_overwrite": [
        "issuetemplate"
    ]
}

Are you using external storage, if yes which one: local/smb/sftp/...

Are you using encryption:

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Client configuration

Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36

The text was updated successfully, but these errors were encountered:

ynjo · 2021-05-15T20:05:15Z

Same issue here

skjnldsv · 2021-05-17T06:15:21Z

@beardhatcode, can you reproduce the double encoding?

beardhatcode · 2021-05-18T06:34:02Z

Yes, I was able to reproduced it last week

beardhatcode · 2021-05-18T19:12:25Z

(I tested in Firefox btw)

stefanroesler · 2021-05-19T09:53:37Z

We also have the problem with version 21.0.2

Tested in Firefox and Chrome, also in the backend nginx or Apache2, unfortunately always the same error. As soon as the file has a space, it does not open it. It works fine without spaces.

ib-mlatin · 2021-05-20T17:26:50Z

I'm having this same issue with version 21.0.2. It was working perfectly in 21.0.1. Using SMB shares, but it also fails with the "test" files that Nextcloud makes for new users. See images below:

obrb · 2021-05-20T17:28:38Z

Actually anything that generates a % in the URL. like Umlauts, #, ?, spaces etc... causes this error. A file named "#PDF mit Abständen und Umlauten.pdf" produces the following error message:

Message: Missing PDF "https://cloud.mydomain.tld/remote.php/dav/files/user/%2523PDF%2520mit%2520Abst%25C3%25A4nden%2520und%2520Umlauten.pdf".

This also happens if the name of a parent folder contains any of these characters or spacing.

Zniets · 2021-05-20T17:57:33Z

Did you all use php8?

ib-mlatin · 2021-05-20T18:30:39Z

Did you all use php8?

No, I'm using the below PHP version:

PHP 7.4.18 (cli) (built: May  3 2021 11:27:06) ( NTS )

szaimen · 2021-05-20T19:28:15Z

I have the same issue now with NC20.0.10 and NC21.0.2
PHP7.4 here

xpfgsyb · 2021-05-20T19:34:34Z

Did you all use php8?

No, NC 21.0.2 with the following PHP version here:
PHP 7.3.27-1~deb10u1 (cli) (built: Feb 13 2021 16:31:40) ( NTS )

fenvarien · 2021-05-20T20:01:11Z

Here we have the same issue with NC 21.0.2 (PHP 7.4.18). To help the students of my school tomorrow, I switched to OnlyOffice as the default PDF viewer as a workaround. But I wonder how this bug could slip through with the release of 21.0.2.
Is it possible to revert to an older version of pdfviewer?

szaimen · 2021-05-20T20:13:01Z

cc @nextcloud/server-triage

JazMTaz · 2021-05-21T01:43:34Z

Same issue here

Nextcloud 20.0.10

Operating System: | Linux 5.4.0-1035-raspi aarch64
Memory: | 7.63 GB

Nginx version: nginx/1.18.0 (Ubuntu)

Database
Type: mysql
Version: 10.3.29

PHP
Version: 7.4.3

pierreGLV9 · 2021-05-21T05:24:50Z

PHP 7.4.9
MariaDB 10.3.24
Nexcloud 21.0.1 : Everythink perfectly worked
Nextcloud 21.0.2 : I encountered the same issue with PDF files, unable to view the files with spaces in name...

chrissi55 · 2021-05-21T05:49:35Z

Same here with PHP 7.4.18 -> NC 21.0.2

Obviously it is not nexcessary that the PDF Filename contains Spaces - one space in the whole path is causing the error

So not just ../My Name.PDF but also /this.is/my path/to.the.file/My-Name.PDF causes the error

beardhatcode · 2021-05-21T08:07:58Z

@skjnldsv , I think it will likely suffice to remove the encode here:

files_pdfviewer/src/views/PDFView.vue

Line 61 in 487c93f

encodedDavPath += '/' + encodeURIComponent(pathSections[i])

The davpath that is returned by viewer is now already "safe" so there is no need to encode it again. I might try this out tonight.

Zniets · 2021-05-21T09:01:07Z

How can I test this?

beardhatcode · 2021-05-21T09:08:57Z

@Zniets, you could edit that file and change the aforementioned line to encodedDavPath += pathSections[i] and compile the new js. And see if this works.

Alternatively, I you don't want to compile, you could edit apps/files_pdfviewer/js/files_pdfviewer-main.js and change

!==i[a]&&(c+="/"+encodeURIComponent(i[a]));return t&&(c=i[0]+"//"+i[2]+c),c}}

to

!==i[a]&&(c+="/"+i[a]);return t&&(c=i[0]+"//"+i[2]+c),c}}

Or even simpler: Just replace
apps/files_pdfviewer/js/files_pdfviewer-main.js on your instance with this file from the PR that should fix the issue.

If you try this out, could you report back if that solved the issue? Thanks 🙂

DmDS · 2021-05-21T09:14:12Z

Alternatively, I ou don't want to compile, you could edit apps/files_pdfviewer/js/files_pdfviewer-main.js and change....

it helped, thanks!

beardhatcode · 2021-05-21T09:28:41Z

@DmDS, do you mean that the proposed edit resolved the issue completely?

DmDS · 2021-05-21T09:33:45Z

@DmDS, do you mean that the proposed edit resolved the issue completely?

yes)

Zniets · 2021-05-21T09:35:16Z

@Zniets, you could edit that file and change the aforementioned line to encodedDavPath += pathSections[i] and compile the new js. And see if this works.

Alternatively, I you don't want to compile, you could edit apps/files_pdfviewer/js/files_pdfviewer-main.js and change
!==i[a]&&(c+="/"+encodeURIComponent(i[a]));return t&&(c=i[0]+"//"+i[2]+c),c}}
to
!==i[a]&&(c+="/"+i[a]);return t&&(c=i[0]+"//"+i[2]+c),c}}
If you try this out, could you report back if that solved the issue? Thanks 🙂

This worked for me

beardhatcode · 2021-05-21T09:59:57Z

Thanks for testing this out @DmDS and @Zniets 👍

mvvvmd · 2021-05-21T10:05:51Z

I can confirm it works again with the change, after clearing the browser cache.

janvier-vip · 2021-05-21T10:53:09Z

@beardhatcode confirmed it fixed the problem. thanks a lot. :)

sinichi19 · 2021-05-24T04:46:32Z

Alternatively, I you don't want to compile, you could edit apps/files_pdfviewer/js/files_pdfviewer-main.js and change
!==i[a]&&(c+="/"+encodeURIComponent(i[a]));return t&&(c=i[0]+"//"+i[2]+c),c}}
to
!==i[a]&&(c+="/"+i[a]);return t&&(c=i[0]+"//"+i[2]+c),c}}
If you try this out, could you report back if that solved the issue? Thanks 🙂

confirmed fixed,

after update to 20.0.10 cant open pdf, but after i tried this is now working .

Thank You Sir

maxrekorder · 2021-05-24T09:14:10Z

Thank you so much for the help. The bugfix works!

In the future it would be nice if the functions of the app were tested before a new update is rolled out.

beardhatcode · 2021-05-24T09:33:30Z

The fix for this issue is not yet merged, to help others find this out I'll reopen the issue

rogercreagh · 2021-05-24T16:45:42Z

Any idea of timescale when this will be available as a release for NC20.x (currently on v2.0.1) that can be installed as an update from within NC for those of us who don't have sudo access to the server? Its a right pain at present - we've had to switch pdf viewing to OpenOffice and it is so slooow. (we have loads of pdf files and folder names with spaces and all was good till we updated to NC20.x this week)

aleskomarek · 2021-05-25T05:22:11Z

This fix repair opening my own PDF files, but does not solve opening shared PDF files.

beardhatcode · 2021-05-25T05:47:43Z

@aleskomarek did you replace the entire file or just the did you just do the mini edit?

aleskomarek · 2021-05-25T06:19:30Z

@aleskomarek did you replace the entire file or just the did you just do the mini edit?

without file replacement or file edition

Oriann · 2021-05-25T06:37:12Z

@aleskomarek wait you said that without any fix you have working pdf viewer from cloud but not from shared link?

aleskomarek · 2021-05-25T06:43:23Z

@aleskomarek wait you said that without any fix you have working pdf viewer from cloud but not from shared link?

sorry for my inaccuracy, i uploaded PDF file to my account and with this fix I opened this file in buildin PDF viewer, but when I shared this file to another user and this user opens this shared file in buildin PDF viewer problem persists - file is missing

beardhatcode · 2021-05-25T06:52:51Z

@aleskomarek , could you ask that other user to clear their browser cache? They are likely still using the old code.

aleskomarek · 2021-05-25T06:54:32Z

@aleskomarek wait you said that without any fix you have working pdf viewer from cloud but not from shared link?

sorry for my inaccuracy, i uploaded PDF file to my account and with this fix I opened this file in buildin PDF viewer, but when I shared this file to another user and this user opens this shared file in buildin PDF viewer problem persists - file is missing

I'm have shared folder to another user and I moved a PDF file to this shared folder. Another user has problem with opening this PDF file in buildin PDF viewer. In NC version 21.0.1 this was ok.

aleskomarek · 2021-05-25T07:19:04Z

@aleskomarek , could you ask that other user to clear their browser cache? They are likely still using the old code.

You are right. Now this is also functional over shared folder/file. Trouble was really in user's web browser. After restart browser and clear cache this is ok. I apologize for my fault.

The errors that required encodeURIComponent in the past have been mittigated by the following commit on nextcloud viewer. nextcloud/viewer@02e1b1a The code with hasScheme may be removed, viewer now returns a full properly encoded URI thanks to the work done in nextcloud-router fixes #381 Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>

The errors that required encodeURIComponent in the past have been mittigated by the following commit on nextcloud viewer. nextcloud/viewer@02e1b1a The code with hasScheme may be removed, viewer now returns a full properly encoded URI thanks to the work done in nextcloud-router fixes #381 Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>

RodSeq · 2021-05-27T07:07:31Z

I confirm I had the same issue after upgrading my instance to NC 21.0.2, now solved with your temporary fix replacing the file "apps/files_pdfviewer/js/files_pdfviewer-main.js" + restarting my browser. Many thanks for your temporary fix for that very critical issue !

Before that a new NC stable version including your fix is released, I suggest that Nextcloud removes 21.0.2 from the "stable" release channel, avoiding that other NC Users experience that critical bug.

Oriann · 2021-05-27T07:19:08Z

@RodSeq totally agree, some users might not be able to fix that easily because lack of experience. Some users may not be even able to access this file location cos of hosting limits.

solracsf · 2021-05-27T08:39:05Z

Please note that "stable" doesn't mean "bug free".
CI tests doesn't cover ALL possible scenarios, in any software.

Last but not least, "stable" also doesn't mean "apply it blindly". 😉
Even more on critical (enterprise) environments.

maxrekorder changed the title ~~Can't open PDF file in viewer when filename is containing a space (' ') in shared folder~~ Can't open PDF file in viewer when filename or foldername is containing a space (' ') May 15, 2021

muchachagrande mentioned this issue May 20, 2021

PDF Viewer can't open files depending on file name nextcloud/server#27045

Closed

szaimen mentioned this issue May 20, 2021

Update Nextcloud 21.0.2 nextcloud-snap/nextcloud-snap#1737

Closed

rakekniven added the bug label May 21, 2021

maxrekorder closed this as completed May 24, 2021

beardhatcode reopened this May 24, 2021

beardhatcode mentioned this issue May 24, 2021

pdf viewer cannot open file from SMB/CIFS external storage. #393

Closed

kesselb mentioned this issue May 25, 2021

external storage and viewing file in embedded browser viewer fails with spaces in file-name nextcloud/server#27093

Closed

skjnldsv closed this as completed in #384 May 25, 2021

Lithimlin mentioned this issue May 26, 2021

Nextcloud - Double encoding of URLs CollaboraOnline/online#2462

Closed

kesselb mentioned this issue May 26, 2021

PDF.js cannot open file with space (%20) in URL nextcloud/server#27116

Closed

szaimen mentioned this issue May 26, 2021

PDF.js stopped working with spaces nextcloud/server#27120

Closed

solracsf mentioned this issue May 27, 2021

Error opening file containing space in file name nextcloud/server#27181

Closed

nextcloud locked as resolved and limited conversation to collaborators May 27, 2021

skjnldsv unpinned this issue Jun 28, 2022

Can't open PDF when filename or folder name contains a space or special character (' ', é, ...) #381

Can't open PDF when filename or folder name contains a space or special character (' ', é, ...) #381

Comments

maxrekorder commented May 15, 2021 • edited by solracsf Loading

🩹 Temporary fix (will be shipped in the next Nextcloud minor release only)

ℹ️ This is a temporary fix you can apply manually, from PR #384. To do this:

1) Replace the file at apps/files_pdfviewer/js/files_pdfviewer-main.js on your instance with this file from that PR

2) Clear your (each user must do it) browser's cache and try to open pdfs. This is a must-do, otherwise, the old file will be loaded from browser's cache !!

Steps to reproduce

Expected behaviour

Actual behaviour

Server configuration detail

Client configuration

ynjo commented May 15, 2021

skjnldsv commented May 17, 2021

beardhatcode commented May 18, 2021

beardhatcode commented May 18, 2021

stefanroesler commented May 19, 2021

ib-mlatin commented May 20, 2021

obrb commented May 20, 2021 • edited Loading

Zniets commented May 20, 2021

ib-mlatin commented May 20, 2021

szaimen commented May 20, 2021 • edited Loading

xpfgsyb commented May 20, 2021

fenvarien commented May 20, 2021

szaimen commented May 20, 2021

JazMTaz commented May 21, 2021

pierreGLV9 commented May 21, 2021

chrissi55 commented May 21, 2021

beardhatcode commented May 21, 2021 • edited Loading

Zniets commented May 21, 2021

beardhatcode commented May 21, 2021 • edited Loading

DmDS commented May 21, 2021

beardhatcode commented May 21, 2021

DmDS commented May 21, 2021

Zniets commented May 21, 2021

beardhatcode commented May 21, 2021

mvvvmd commented May 21, 2021

janvier-vip commented May 21, 2021

sinichi19 commented May 24, 2021 • edited Loading

maxrekorder commented May 24, 2021

beardhatcode commented May 24, 2021

rogercreagh commented May 24, 2021

aleskomarek commented May 25, 2021

beardhatcode commented May 25, 2021

aleskomarek commented May 25, 2021

Oriann commented May 25, 2021

aleskomarek commented May 25, 2021

beardhatcode commented May 25, 2021

aleskomarek commented May 25, 2021

aleskomarek commented May 25, 2021

RodSeq commented May 27, 2021

Oriann commented May 27, 2021

solracsf commented May 27, 2021

maxrekorder commented May 15, 2021 •

edited by solracsf

Loading

1) Replace the file at `apps/files_pdfviewer/js/files_pdfviewer-main.js` on your instance with this file from that PR

obrb commented May 20, 2021 •

edited

Loading

szaimen commented May 20, 2021 •

edited

Loading

beardhatcode commented May 21, 2021 •

edited

Loading

beardhatcode commented May 21, 2021 •

edited

Loading

sinichi19 commented May 24, 2021 •

edited

Loading