Use postCreate to listen for new files #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
I vaguely remember there being a reason that it was done this way, maybe to ensure that outside changes that were scanned are also tagged |
|
@icewind1991 ah mmm that might make sense... However then we'd need a different solution. (or maybe both?) |
|
Well even when it's not using .part files, the files should be added to the cache at some point, which is the moment when the tagging happens (otherwise we don't have a file id). Can you step through with a debugger to see why it's not happening? Is the CacheWrapper maybe not added? |
|
Ok so it seems nextcloud/server#10109 is to blame |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code a bit IMO.
Also it make sure that now automated tagging also works on storages where no partfiles are needed.
@icewind1991 I need your FS expertise to tell me this is good enough ;)
Fixes #53