Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Symantec ICAP #375

Closed
wants to merge 1 commit into from
Closed

Conversation

enjeck
Copy link

@enjeck enjeck commented Sep 12, 2024

This provides Symantec antivirus support

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@icewind1991
Copy link
Member

From what I can tell the main difference between this and the existing icap implementation is the handling of the X-Error-Code reply header. I'll look into adding that logic to the existing icap scanner instead of duplicating the logic.

@Philldomd
Copy link

Philldomd commented Sep 16, 2024

Hi that is correct, all we did was to add error handling from Symantec as it sends 500 codes back. I also added a choice for password protected files as it does mark them in Symantec, not a virus but still 500 return code.

I was uncertain about these rows:
a99e80c#diff-a33d182d4905d83769450f1fc22983b023638ee35cec5d842f24ae390204a5f4R148-R149

It might be better to dont allow this files than mark them as unchecked.

@icewind1991
Copy link
Member

I guess the best way forward is to introduce an "unable to scan" result (separate from the "try to rescan later") and let the admin configure to either allow or block those files. That would then also include password protected files.

@icewind1991
Copy link
Member

wip: #378

@AndyScherzinger
Copy link
Member

@icewind1991 with #378 merged and afaik tested by the customer-feature-requests, can this PR be closed as bring obsolete? Cc @Philldomd for feedback.

@icewind1991
Copy link
Member

icewind1991 commented Oct 9, 2024

Yes this can be closed, I'll try to do a release soon.

Edit: done

@icewind1991 icewind1991 closed this Oct 9, 2024
@AndyScherzinger AndyScherzinger deleted the feat/symantecICAP branch October 9, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants