Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the mountPoint property is public before using it #74

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Make sure the mountPoint property is public before using it #74

merged 2 commits into from
Sep 22, 2017

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 9, 2017 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Aug 9, 2017
@matt-horwood-mayden
Copy link

I have installed version 1.2.4 and I get the below error!

2017/09/22 11:04:23 [error] 18392#0: *4766 FastCGI sent in stderr: "PHP message: PHP Fatal error: Cannot access private property OC\Files\Storage\Wrapper\Encryption::$mountPoint in /var/data/websites/3rd_party/horwood_nextcloud/apps/files_accesscontrol/lib/Operation.php on line 85" while reading response header from upstream, client: 81.138.237.78, server: owncloud.horwood.biz, request: "GET /remote.php/webdav/Mortgage/Payslip%20for%20Tax%20Month_5%2C%20Tax%20Year_2017-2018.pdf?downloadStartSecret=m8lobczwwv HTTP/1.1", upstream: "fastcgi://192.168.49.203:9000", host: "owncloud.horwood.biz"

@nickvergessen
Copy link
Member Author

Does this patch fix it for you?

@matt-horwood-mayden
Copy link

Hi @nickvergessen,
Yes that fixes the issue, have added by hand.

@nickvergessen
Make sure the mountPoint property is public before using it
ddee190 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the check-if-mount-point-property-is-readable branch from acc4174 to ddee190 Compare September 22, 2017 12:41
@nickvergessen
Copy link
Member Author

Rebased to make unit tests pass

@nickvergessen nickvergessen mentioned this pull request Sep 22, 2017
Merged
@nickvergessen
Add changelog
2cbe27f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Released 1.2.5 with this fix

@nickvergessen nickvergessen reopened this Sep 22, 2017
@nickvergessen nickvergessen merged commit 5ed01ab into master Sep 22, 2017
@nickvergessen nickvergessen deleted the check-if-mount-point-property-is-readable branch September 22, 2017 13:01
@emagri emagri mentioned this pull request Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.

Cannot access private property OC\Files\Storage\Wrapper\Encryption
2 participants
@nickvergessen @matt-horwood-mayden