Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate to nextcloud-vue v8 and dialogs v5 #709

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 31, 2024

Modernize the code by using latest versions of our libraries, this also fixes some visual issues with nextcloud 30.

@susnux susnux added 3. to review Waiting for reviews bug Something isn't working design Related to the design labels Jul 31, 2024
@susnux susnux added this to the Nextcloud 30 milestone Jul 31, 2024
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Aug 8, 2024

/compile amend/

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
Copy link
Contributor Author

susnux commented Aug 8, 2024

NPM build Expected — Waiting for status to be reported

This will never turn green as that CI does not exist anymore, can someone maybe remove that from the required list?

@AndyScherzinger AndyScherzinger merged commit cb2e07a into master Aug 8, 2024
37 checks passed
@AndyScherzinger
Copy link
Member

Force merged since I lack the knowledge on how to remove the required state of the obsolete GH action.

@AndyScherzinger AndyScherzinger deleted the chore/refactor branch August 8, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Typo on <script> tag of AdminSection causes all buttons to look misplaced
2 participants