Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SAMEORIGIN header from nginx config doc #1703

Closed
wants to merge 1 commit into from
Closed

Remove SAMEORIGIN header from nginx config doc #1703

wants to merge 1 commit into from

Conversation

ogasser
Copy link
Contributor

@ogasser ogasser commented Nov 14, 2019

Removes the SAMEORIGIN header from the nginx configuration documentation as this is handled by PHP directly.

Fixes #1701

@ogasser
Remove SAMEORIGIN header from nginx config doc
a22365d 
Removes the SAMEORIGIN header from the nginx configuration documentation as this is handled by PHP directly.

Fixes #1701
@kesselb
Copy link
Contributor

kesselb commented Nov 16, 2019

Thanks 👍

For Nextcloud 17 the X-Frame-Options is required: nextcloud/server#16179. The release notes are outdated.

@ogasser
Copy link
Contributor Author

ogasser commented Nov 16, 2019

Thanks for clarifying! 👍

@ogasser ogasser closed this Nov 16, 2019
@skjnldsv skjnldsv deleted the ogasser-patch-1 branch November 16, 2019 10:29
@skjnldsv skjnldsv mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer Awaiting requested review from rullzer

@blizzz blizzz Awaiting requested review from blizzz

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove SAMEORIGIN header from nginx config
2 participants
@ogasser @kesselb