Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update atomiccomponents docs #10399

Merged
merged 8 commits into from
Jun 12, 2023
Merged

update atomiccomponents docs #10399

merged 8 commits into from
Jun 12, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 16, 2023 •
edited
Loading

Address part of #10392

TODO:

  • Update all screenshots
  • update links
  • move links to top?
  • add links to penpot
  • add missing components?
  • address reviews

@szaimen szaimen added this to the Nextcloud 27 milestone May 16, 2023
@szaimen szaimen force-pushed the enh/noid/update-atomic-componets branch from dfb22b9 to 5ffab22 Compare May 17, 2023 16:25
@szaimen
update atomiccomponents docs
5e7838d 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/update-atomic-componets branch from 5ffab22 to 5e7838d Compare May 17, 2023 16:29
@szaimen
update links
b7840b5 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
move links to top and add some links
29abd2e 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen marked this pull request as ready for review May 23, 2023 15:17
@szaimen szaimen requested a review from nimishavijay May 23, 2023 15:17
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@szaimen
add penpot links
9c7c294 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
add counter bubbles component
32688c5 
Signed-off-by: Simon L <szaimen@e.mail.de>
jancborchardt
jancborchardt previously requested changes May 24, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments. :)

@szaimen szaimen requested a review from nimishavijay June 1, 2023 14:07
@szaimen szaimen force-pushed the enh/noid/update-atomic-componets branch from e58cd48 to 9e91db7 Compare June 1, 2023 22:40
@szaimen szaimen requested review from jancborchardt and removed request for jancborchardt June 1, 2023 22:41
@szaimen
address review
02a3c92 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/update-atomic-componets branch from 9e91db7 to 02a3c92 Compare June 1, 2023 22:56
@szaimen
fix deck screenshot
3a41ff3 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
fix the counter-bubble
04ff5c5 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen requested review from nimishavijay and jancborchardt and removed request for nimishavijay and jancborchardt June 8, 2023 15:36
@szaimen
Copy link
Contributor Author

szaimen commented Jun 8, 2023

@jancborchardt @nimishavijay can you please approve? Should everything be fixed or reported now :)

@szaimen szaimen requested review from nimishavijay and jancborchardt and removed request for nimishavijay and jancborchardt June 9, 2023 09:00
marcoambrosini
marcoambrosini approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen
Copy link
Contributor Author

szaimen commented Jun 12, 2023

Thanks Marco! :)

@szaimen szaimen merged commit ad1dc52 into master Jun 12, 2023
@szaimen szaimen deleted the enh/noid/update-atomic-componets branch June 12, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
3. to review design enhancement
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@szaimen @jancborchardt @marcoambrosini @blizzz