Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-nginx-proxy/mariadb-cron-redis/fpm/docker-compose.yml #514

Closed
wants to merge 21 commits into from
Closed

Conversation

Tockra
Copy link
Contributor

@Tockra Tockra commented Oct 15, 2018

- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
    Changed version to 10.3 because: #503
    Added "--log-bin=mysqld-bin" caused of startup Warning.
- Changed version to 10.3 because: #503
- Added "--log-bin=mysqld-bin" caused of startup Warning.
@pierreozoux
Copy link
Member

Can you put #505 here too? Thanks!

@Tockra
Copy link
Contributor Author

Tockra commented Oct 15, 2018

Okay, sorry I'm not so familar with git and the problem at first was I added the changes via github webpanel.
I hope I fixed it right ;)

@pierreozoux
Copy link
Member

No ptoblems, we are all learning ;)

I recommend reading https://nvie.com/posts/a-successful-git-branching-model/
In this case it is a feature branch (or maybe a bug branch)

Coming back to our PR:
Pinning the version is always a good thing, but it is time consuming to maintain.
Except if we have automation to always update to latest and check it is working as expected.
We already have CI integration with docker, but it merely test the docker image itself.
We could have a CICD for docker compose too.
It looks like one more argument to have it in its own repo.

This bin log argument, can you point me to the documents that states that it was not needed before and is needed now? I'm curious.

Thanks a lot for your contribution.

I'm curious about the thoughts of other maintainers?
(On mobile, I can't ping people..)

@Tockra
Copy link
Contributor Author

Tockra commented Oct 16, 2018

This bin log argument, can you point me to the documents that states that it was not needed before and is needed now? I'm curious.

There is no documentation about it but if you don't use log-bin you'll get this warning:
[Warning] You need to use --log-bin to make --binlog-format work.

@pierreozoux
Copy link
Member

Ok, so this fixes the warning, sounds legit to me.
About the pinning of the mysql version, it is just because the upper version doesn't work?
Do you know the cause?

@Tockra
Copy link
Contributor Author

Tockra commented Oct 17, 2018

Do you know the cause?

I don't know why it doesn't work. But I think to pin the version until it is fixed is a good idea.

@Tockra
Copy link
Contributor Author

Tockra commented Oct 22, 2018

Merge or not merge that is the question!?

@J0WI
Copy link
Contributor

J0WI commented Jun 14, 2019

@Tockra
Copy link
Contributor Author

Tockra commented Jun 24, 2019

@J0WI
Copy link
Contributor

J0WI commented Jun 24, 2019

Yes, meanwhile 10.4 is out, so now it's an alias for that version (which is compatible with NextCloud).

@Tockra
Copy link
Contributor Author

Tockra commented Jun 24, 2019

Yes, meanwhile 10.4 is out, so now it's an alias for that version (which is compatible with NextCloud).

I remember that at the moment I posted this Issue 10.3 wasn't equal latest.
Are you sure you are right? Did you try to sync 1 GB or more small files (1-10Mbyte) via Nextcloud with a fast connection (1Gbit/s (LAN/Ethernet)) to your server (in the same network)? In this cases I got locks even before 1 month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Compose/Dockerfile/etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants