Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/client status reporting #6247

Merged
merged 9 commits into from
Dec 11, 2023
Merged

Feature/client status reporting #6247

merged 9 commits into from
Dec 11, 2023

Conversation

allexzander
Copy link
Contributor

Implements #6124

@allexzander
Copy link
Contributor Author

@tobiasKaminsky

github-actions[bot]
github-actions bot requested changes Nov 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/libsync/clientstatusreporting.h Show resolved Hide resolved
src/libsync/clientstatusreporting.cpp Outdated Show resolved Hide resolved
src/libsync/clientstatusreporting.cpp Outdated Show resolved Hide resolved
@joshtrichards joshtrichards linked an issue Nov 29, 2023 that may be closed by this pull request
Report client status #6124
Closed
@joshtrichards joshtrichards mentioned this pull request Nov 29, 2023
Closed
@allexzander allexzander force-pushed the feature/client-status-reporting branch from 0521d9b to 6a0eb55 Compare November 30, 2023 16:05
mgallien
mgallien requested changes Dec 6, 2023
View reviewed changes
src/gui/tray/NCBusyIndicator.qml Outdated Show resolved Hide resolved
src/libsync/account.h Outdated Show resolved Hide resolved
src/libsync/account.cpp Outdated Show resolved Hide resolved
src/libsync/account.cpp Outdated Show resolved Hide resolved
src/libsync/account.h Outdated Show resolved Hide resolved
src/libsync/clientstatusreporting.h Outdated Show resolved Hide resolved
src/libsync/clientstatusreporting.h Outdated Show resolved Hide resolved
src/libsync/clientstatusreportingrecord.cpp Outdated Show resolved Hide resolved
src/libsync/owncloudpropagator.cpp Outdated Show resolved Hide resolved
src/libsync/owncloudpropagator_p.h Show resolved Hide resolved
@allexzander allexzander force-pushed the feature/client-status-reporting branch from 4284bf6 to 61ef286 Compare December 6, 2023 18:39
@allexzander allexzander force-pushed the feature/client-status-reporting branch from 2091121 to 79e124c Compare December 7, 2023 13:20
mgallien
mgallien requested changes Dec 11, 2023
View reviewed changes
src/libsync/clientstatusreporting.cpp Outdated Show resolved Hide resolved
src/libsync/clientstatusreportingcommon.cpp Outdated Show resolved Hide resolved
src/libsync/clientstatusreportingcommon.h Outdated Show resolved Hide resolved
src/libsync/clientstatusreportingnetwork.h Outdated Show resolved Hide resolved
src/libsync/owncloudpropagator_p.h Outdated Show resolved Hide resolved
@mgallien mgallien force-pushed the feature/client-status-reporting branch from 2765247 to 30502da Compare December 11, 2023 15:05
@allexzander
Client status reporting feature. First iteration.
972700b 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Send status report. Improved logic and database columns.
0561541 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Iteration. Use Capabilities to control Client Status Reporting availi…
a3ffd63 
…bility.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Iteration. Properly process server reply.
3c76931 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Generate client status report records when errors happen.
04faef3 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/client-status-reporting branch from 30502da to 7fb3a29 Compare December 11, 2023 15:23
@allexzander
Prevent issues when changing the enum.
8427f9a 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Allow sending E2EE and Virus_Detected statuses. Also updated tests.
1828c4f 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Report error Virus Detected. Updated tests.
895950a 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/client-status-reporting branch 2 times, most recently from 97e7397 to 92d005b Compare December 11, 2023 16:06
@allexzander allexzander force-pushed the feature/client-status-reporting branch from 92d005b to 846d435 Compare December 11, 2023 16:18
@allexzander
Added error reporting for E2EE issues.
9d5d2df 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/client-status-reporting branch from 846d435 to 9d5d2df Compare December 11, 2023 16:29
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 70 Code Smells

70.8% 70.8% Coverage
0.6% 0.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6247-9d5d2df329bbf55de14c10b0e1f2a311620bbe86-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 50d1687 into master Dec 11, 2023
9 of 12 checks passed
@allexzander allexzander deleted the feature/client-status-reporting branch December 11, 2023 17:03
@allexzander
Copy link
Contributor Author

/backport to stable-3.11

@allexzander allexzander modified the milestone: 3.11.0 Dec 11, 2023
@allexzander allexzander mentioned this pull request Dec 11, 2023
Merged
@mgallien mgallien added this to the 3.12.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Report client status
3 participants
@allexzander @nextcloud-desktop-bot @mgallien