-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new file details window, unify file activity and sharing #4929
Conversation
1bb03f6
to
25e5f2a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4929 +/- ##
==========================================
+ Coverage 57.22% 57.66% +0.44%
==========================================
Files 138 138
Lines 17441 17418 -23
==========================================
+ Hits 9980 10044 +64
+ Misses 7461 7374 -87
|
772f326
to
deed325
Compare
09679c8
to
4a427b0
Compare
4a427b0
to
0c623f2
Compare
@nimishavijay @marcoambrosini would love to get your feedback on this cause I looked at it so much already, would be cool to get new input. :) |
Super super great work! Love the animation for switching between activity and sharing :D I have some feedback, but not sure how much of it is feasible:
What do you think? |
So I'm lacking context here and this is a quick impression from the top of my head. |
eg: we could have a share settings page for each share similar to google drive. And in files this should prob be a dialog Screen.Recording.2022-09-15.at.16.27.59.mov |
Yes, @jancborchardt has already shown mockups of a share settings page rather than a pop-up. However this PR is already massive and I thought it best for the sake of my fellow desktop team members' sanity to leave this for a different pull request :) |
This is doable
Sorry, do you have an example of what this would look like? We don't use these variables in the desktop client Are you sure we also want to differ from the way it looks in the server?
Sure, no problem
As soon as you confirm the input this gets set to the server, which replies with a valid date. So if today is 15/09/2022 and you try to set 14/09/2022 the date field will send this data, show a loading indicator, and reset to the 15/09/2022 date which the server forces. If you enforce a maximum 7 day expire days and try to set an expire date further in the future than that, the max expire date gets set This is an independent component that is used elsewhere in the client, not just in this PR. We can certainly change the design -- I will open an issue and we can put it on the task list :)
Yes, this should be possible.
Not possible. The error messages come from the server and we have no way of knowing, from the desktop client side, why exactly the password has been rejected specifically. We only receive a notice that the password was rejected and a string with the error message from the server Yes, we have discussed this. But like with Marco's feedback this is already a massive PR and it is something that can be worked on separately. Also, more specifically, native style will take a lot of work to do at the moment. We are planning to move to Qt 6 in the near future which should make this much more trivial to implement -- right now we would be forced to design checkboxes specific to each operating system, which is IMO not the way to go
Sure, can do I have added the stuff we can do in this PR to the PR description at the top |
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…file detail dialogs, raise existing dialog instead of always deleting Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Test ShareModel error handling Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Improve testing of user/group shares in ShareModel Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> Add testing for maximum share expire date enforcement in ShareModel Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…reTestUtils file Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
e7b85db
to
d79312b
Compare
AppImage file: nextcloud-PR-4929-d79312b2f7d32af4565221aab71cf694cad917cf-x86_64.AppImage |
SonarCloud Quality Gate failed. 0 Bugs |
HI @claucambra The auto password generator is not working on client 3.7.4 tested on windows once i click on share via lin i get an option to set password and dose not auto generate |
This rather big PR contains the following changes:
These changes have the following advantages:
Some screengrabs:
Screen.Recording.2022-09-12.at.18.20.58.mov
Screen.Recording.2022-09-12.at.18.15.35.mov
Screen.Recording.2022-09-12.at.18.16.22.mov
Screen.Recording.2022-09-12.at.18.16.43.mov
Screen.Recording.2022-09-12.at.18.18.33.mov
Screen.Recording.2022-09-12.at.18.18.50.mov
Closes #3845, closes #4777, closes #4947
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com