-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote wipe. #1504
Remote wipe. #1504
Conversation
camilasan
commented
Oct 12, 2019
•
edited by misch7
Loading
edited by misch7
- amend git comment
- more testing
- test on Windows
Cool, I want to see this in action :-) Drone build failed, seems like the implementations of the
But Drone did not fail for Debian and AppImage (the latter one failed because of an upload error). Perhaps just a problem in test compilation?
And it doesn't find |
They are signals. |
106517e
to
67997f0
Compare
…quested. - When the the users logs because of 401 or 403 errors, it checks if the server requested the remote wipe. If yes, locally deletes account and folders connected to the account and notify the server. If no, proceeds to ask the user to login again. - The app password is restored in the keychain. - WIP: The change also includes a test class for RemoteWipe. Signed-off-by: Camila San <hello@camila.codes>
67997f0
to
19491ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for RC1 :)
Looks good so far and works well with HTTP connections.
TODO: Still not working with SSL connections (tested on Mac and Windows).
Fixed by PR #1579
/backport to stable-2.6 |
The backport to stable-2.6 failed. Please do this backport manually. |