Avoiding copying in range-based loops #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asapelkin
force-pushed
the
for_loop_optimization
branch
from
93a0278
to
eddc346
Compare
Signed-off-by: asapelkin <asapelkin0x01@ya.ru>
asapelkin
force-pushed
the
for_loop_optimization
branch
from
eddc346
to
17f39bd
Compare
DominiqueFuchs
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Good catch @asapelkin - thanks for contributing! Changes are fine by me
DominiqueFuchs
added
the
enhancement
|
/backport to stable-2.6 |
|
The backport to stable-2.6 failed. Please do this backport manually. |
|
/backport to stable-2.6 |
|
The backport to stable-2.6 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization. Used const references in range-based loops to avoid copying every items