Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double slashes #1414

Merged
merged 6 commits into from
Sep 12, 2019
Merged

Fix double slashes #1414

merged 6 commits into from
Sep 12, 2019

Conversation

misch7
Copy link
Member

@misch7 misch7 commented Sep 11, 2019

Sanitize URL paths to eliminate double-slashes

Purpose: Don't rely on unsafe paths, be extra careful.

Example: https://cloud.example.com/remote.php/webdav//

Seems to work and is intended to be placed there for extra caution ;-)
What do you think @rullzer @camilasan ? 😼

Sanitize URL paths to elaminate double-slashes in the URL path string,
used for the first connection by the account setup wizard.

Example: https://cloud.example.com/remote.php/webdav//

Signed-off-by: Michael Schuster <michael@schuster.ms>
Signed-off-by: Michael Schuster <michael@schuster.ms>
@misch7 misch7 requested a review from rullzer September 11, 2019 16:02
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@misch7 misch7 merged commit d6fce49 into master Sep 12, 2019
@misch7 misch7 deleted the fix-double-slashes branch September 12, 2019 19:25
@misch7
Copy link
Member Author

misch7 commented Oct 4, 2019

/backport to stable-2.6

@backportbot-nextcloud
Copy link

The backport to stable-2.6 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants