Qt5.5 compatiblity patch for login flow V2 #1392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
|
@ivaradi Thanks for pointing that out and providing a fix. 👍 It's worth mentioning that this originates from OAuth and should be fixed there too: src/gui/wizard/owncloudoauthcredspage.cpp Anyhow I don't like the right-click thing since it's not intuitive for the user. I tend to remove this feature and replace it with a dedicated button below the "Re-open" button if you're all okay with that. |
|
@misch7 src/gui/wizard/owncloudoauthcredspage.cpp is already patched by the patch. It is OK with me if you remove the right-click feature, and in that case this PR is not need. If you also remove it from owncloudoauthcredspage.cpp, then a new PR will be necessary to remove the patching of that file. |
Closed
misch7
added a commit
that referenced
this pull request
Sep 6, 2019
Removes the right-click function for the "Re-open browser" buttons because they are not intuitive for the user. Adds a dedicated "Copy link" button. Implements Qt 5.5 fixes based on: #1392 Signed-off-by: Michael Schuster <michael@schuster.ms>
Closed
misch7
added a commit
that referenced
this pull request
Sep 6, 2019
Removes the right-click function for the "Re-open browser" buttons because they are not intuitive for the user. Adds a dedicated "Copy link" button. Implements Qt 5.5 fixes based on: #1392 Signed-off-by: Michael Schuster <michael@schuster.ms>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new login flow implementation contained some code that is incompatible with Qt 5.5 used when building for Xenial. This patch extends the compatibility patch with changes that modify the code to be compatible with Qt 5.5.