-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slideshow buttons #1149
slideshow buttons #1149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great design-wise! :)
After digging this PR out I ran some tests to see if this could happily be merged after the positive design reactions. Unfortunately, several months later the result is a mess without further modifications (screen attached):
Any comments if fixing and adaption to current state is still desired? If yes, I could do this (should @IzabelaBakollari be out of reach in the meantime), otherwise I'd close this. |
@DominiqueFuchs would really be cool to fix this if you are up for it. :) It was reported as an accessibility issue. |
…in wizard Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…sktop into bugfixing-slideshow
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…sktop into bugfixing-slideshow
…itions through the last months) Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Done:
Builds fine everywhere, looks fine on Windows (only build/test system with a GUI on my side ATM) Button svg: Build result: 🦊 approve, @jancborchardt ? |
@DominiqueFuchs nice work! :) The only thing is that there’s too much blue there. Only the header and the primary button (in this case "Register with a provider") should be blue now, but not the prev/next icons, and also not the icons and the text. So likely one version for light backgrounds and one for dark. But we could also do that in a separate pull request to do small steps but quickly – also cause text and icons being blue was like that before already. :) |
…for wizard slide buttons Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…ility refinements and thus implementation of helper fct. to retrieve themed QIcons. Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…ection logic Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…sktop into bugfixing-slideshow
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
@jancborchardt Sorry, before your last comment I did not notice the referenced issue, thanks for clarifying anyway! Summary of changes:
Windows (Gnome also tested, runs fine but looks essentially the same as expected): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! 👍 I have some more design ideas for the setup process, but that’s a follow-up pull request, maybe best at the conf or at a contributor week. :)
Added slideshow buttons and changed color of the link "Host your own server".