Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS Finder Sidebar Icon Issue #1187

Closed
rawbertp opened this issue Apr 5, 2019 · 7 comments
Closed

MacOS Finder Sidebar Icon Issue #1187

rawbertp opened this issue Apr 5, 2019 · 7 comments

Comments

@rawbertp
Copy link

rawbertp commented Apr 5, 2019

Expected behaviour

I don't know what the Finder sidebar icon (favorites) actually should look like, probably like a nice little folder or so.

Actual behaviour

A boring gray box is shown instead.
Bildschirmfoto 2019-04-05 um 10 33 30

Steps to reproduce

  1. Set up a synced folder in NC client
  2. Open finder

Client configuration

Client version: 2.5.1final (build 20181204)

Operating system: macOS Mojave 10.14.4 (18E226)

OS language: German

@mylos
Copy link

mylos commented Apr 5, 2019

Same problem on my Mac as well.
Client version: 2.5.1final (build 20181204)
Operating system: macOS Mojave 10.14.4 (18E226)
OS language: English

@rawbertp
Copy link
Author

rawbertp commented Apr 13, 2019

BTW it is working as expected with the Owncloud desktop client, so this definitely is an issue within the Nextcloud fork.

(May be related to that commit? aa7e47f)

@maghog
Copy link

maghog commented Apr 13, 2019

Same problem:
Client Version 2.5.2git (build 20190319)
macOS v10.13.6

@Javihache
Copy link

Same Problem with 2.5.1final (build 20181204) on Mac OS Mojave 10.14.5

@ntompson
Copy link

ntompson commented Jul 2, 2019

Same problem for me. Client version 2.5.2git (build 20190319), macOS Mojave 10.14.5. I wonder: what should the icon look like?

@gt-h6k
Copy link
Member

gt-h6k commented Jul 11, 2019

The sidebar is a gray icon because is not transparent background.
Resolved using logo icon without background color.

https://developer.apple.com/library/archive/documentation/General/Conceptual/ExtensibilityPG/Finder.html#//apple_ref/doc/uid/TP40014214-CH15-SW15

3.Create a complete set of sidebar icons. These icons must be template images—monochromatic images that are drawn just using black and transparency. The icons must use the following filenames and sizes:

camilasan pushed a commit that referenced this issue Jul 22, 2019
@tobiasKaminsky tobiasKaminsky removed this from the 2.5.3 🐛 Bug fixes milestone Aug 5, 2019
@tobiasKaminsky
Copy link
Member

PR was merged too late, will be in 2.5.4 (if) or 2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants