Label editing in board sidebar #935
Conversation
moved to first post |
| <template v-if="editingLabelId === label.id"> | ||
| <input v-model="editingLabel.title"><input v-model="editingLabel.color"> | ||
| <button class="icon-checkmark" @click="updateLabel(label)" :disabled="!editLabelObjValidated" | ||
| v-tooltip="{content: 'title and color must be provided', |
There was a problem hiding this comment.
Please use a translatable string there
There was a problem hiding this comment.
@jakobroehrl Some minor comments. Besides that it looks good. 👍
|
@jakobroehrl I also updated the TODO list in the original post. |
juliusknorr
force-pushed
the
vue-board-sidebar
branch
from
b3c569b
to
6efca19
Compare
jakobroehrl
force-pushed
the
vue-board-sidebar
branch
from
6efca19
to
b7383d2
Compare
| <span :style="{ backgroundColor: `#${label.color}`, color:textColor(label.color) }" class="label-title"> | ||
| <span v-if="label.title">{{ label.title }}</span><i v-if="!label.title"><br></i> | ||
| </span> | ||
| <button v-tooltip="t('deck', 'Edit')" class="icon-rename" @click="clickEdit(label)" /> |
There was a problem hiding this comment.
| <button v-tooltip="t('deck', 'Edit')" class="icon-rename" @click="clickEdit(label)" /> | |
| <button v-tooltip="t('deck', 'Edit')" class="icon-rename" @click="clickEdit(label)" /> |
|
@jakobroehrl Looks good appart from my small change requests 👍 We definitely still need to do some polishing of the color picker, so that it properly fits into the sidebar, but I'm fine with doing that in a separate pull request. We should try to get this merged to the vue branch, and continue with the other sidebar tabs in separate pull requests. |
I've created a ColorPicker-Component in the vue branch, so we can just use that once we merged your branch back. 😉 |
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
juliusknorr
force-pushed
the
vue-board-sidebar
branch
from
7b25bdf
to
3f272b9
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
vue-board-sidebar
branch
from
5307ae9
to
643797d
Compare
|
Thanks a lot for all the work @jakobroehrl 🎉 |
Signed-off-by: Jakob Röhrl jakob.roehrl@web.de
Summary
TODO
Note the color type of input fields as we use it right now in the angular version doesn't work with safari, so feel free to hook in some color picker library for the custom colors like https://xiaokaike.github.io/vue-color/
Checklist