Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve card title editing #6327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve card title editing #6327

wants to merge 2 commits into from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 18, 2024

  • fix: Fix title selection and editing
  • fix: Inline links in card title

This addresses a couple of usability issues with the inline card title editing, by making it disabled by default. We add a new edit title menu entry, but otherwise just open the card on click.

Additionally this allows marking text on deck cards and is rendering clickable links.

Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr juliusknorr changed the title fix/card title Improve card title editing Sep 19, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inlineEditingBlocked computed doesn't seem to be used anymore.

@luka-nextcloud
Copy link
Contributor

It works well. BTW, I think we should autofocus the card title when user select menu "Edit title". Currently, after selecting "Edit title", user has to click on card title to edit it.

@juliusknorr
Copy link
Member Author

Yes, that is the main issue I'm still struggling with :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants