-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy labels when moving cards between boards #6257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a quick code review and I am wondering whether or not there should be permission check (I think the "manage board" permission is required when a user wants to create new labels)? |
juliusknorr
reviewed
Aug 26, 2024
juliusknorr
reviewed
Aug 26, 2024
juliusknorr
reviewed
Aug 26, 2024
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
grnd-alt
force-pushed
the
fix/no-cross-referencing-in-labels
branch
from
August 28, 2024 09:59
8718bbd
to
dbca6bc
Compare
juliusknorr
approved these changes
Aug 29, 2024
@grnd-alt Backports? |
/backport to stable28 |
/backport to stable29 |
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
labels assigned to cards that move between boards now get cloned
old json deck files that have cross referencing labels now skip those labels instead of throwing an error
Checklist