Change formatter prop from :format to :formatter #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In vue2-datepicker 3.6.3 the `format` got renamed to `formatter` See nextcloud-libraries/nextcloud-vue#1495 (comment) Closes #2551 Signed-off-by: Michał Zając <michal.zajac@gmail.com>
GretaD
approved these changes
Jan 13, 2022
|
i didnt test it but looks good |
GretaD
added
4. to release
Codecov Report
@@ Coverage Diff @@
## main #2596 +/- ##
=========================================
Coverage 69.25% 69.25%
Complexity 247 247
=========================================
Files 21 21
Lines 696 696
=========================================
Hits 482 482
Misses 214 214 Continue to review full report at Codecov.
|
ChristophWurst
approved these changes
Feb 2, 2022
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vue2-datepicker 3.6.3 the
formatgot renamed toformatterSee nextcloud-libraries/nextcloud-vue#1495 (comment)
Closes #2551