Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule proposal nullable_type_declaration #29

Closed
kesselb opened this issue Aug 30, 2024 · 3 comments · Fixed by #33
Closed

Rule proposal nullable_type_declaration #29

kesselb opened this issue Aug 30, 2024 · 3 comments · Fixed by #33

Comments

@kesselb
Copy link
Contributor

kesselb commented Aug 30, 2024

https://cs.symfony.com/doc/rules/language_construct/nullable_type_declaration.html

Changes DateTimeInterface|null to ?DateTimeInterface

'nullable_type_declaration' => ['syntax' => 'question_mark'],

25 files in server affected
@nickvergessen
Copy link
Member

How does it handled string|int|bool|null ?

@kesselb
Copy link
Contributor Author

kesselb commented Sep 9, 2024

How does it handled string|int|bool|null ?

They are skipped.

@nickvergessen
Copy link
Member

Then I'm fine with the rule!

kesselb added a commit that referenced this issue Sep 18, 2024
@kesselb
style: add concat_space and nullable_type_declaration
27a82a6 
Ref #29
Ref #30

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb mentioned this issue Sep 18, 2024
Merged
kesselb added a commit that referenced this issue Sep 18, 2024
@kesselb
style: add concat_space and nullable_type_declaration
012e82b 
Ref #29
Ref #30

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 18, 2024
@kesselb
style: add concat_space and nullable_type_declaration
92003fa 
Ref #29
Ref #30

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb added a commit that referenced this issue Sep 18, 2024
@kesselb
style: add concat_space and nullable_type_declaration
d150d95 
Ref #29
Ref #30

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add contact_space and nullable_type_declaration nextcloud/coding-standard
2 participants
@nickvergessen @kesselb