Skip to content

Commit

Permalink
Merge pull request #16 from nextcloud/nickvergessen-patch-1
Browse files Browse the repository at this point in the history
fix: Remove fully_qualified_strict_types again
  • Loading branch information
nickvergessen authored Feb 1, 2024
2 parents 424cdd9 + 35fd40e commit cf5f18d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
# Changelog
All notable changes to this project will be documented in this file.

## 1.2.1 - 2024-02-01
### Fix
* fix: Remove `fully_qualified_strict_types` again by @nickvergessen in https://github.com/nextcloud/coding-standard/pull/16

## 1.2.0 - 2024-02-01
### Added
- `array_syntax`: Force short syntax for array
- `list_syntax`: Same for list
- `fully_qualified_strict_types`: Remove namespace from classname when there is a `use` statement, and add missing backslash for global namespace
- ~~`fully_qualified_strict_types`: Remove namespace from classname when there is a `use` statement, and add missing backslash for global namespace~~ - Removed in 1.2.1 due to issues
- `no_leading_import_slash`: Remove leading slash from `use` statement
- `nullable_type_declaration_for_default_null_value`: Add missing `?` on type declaration for parameters defaulting to `null`. This will most likely be needed to avoid warnings in PHP 8.4.
- `yoda_style`: forbid yoda style comparision. This replaces `null === $a` by `$a === null`.
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ For convenience you may add it to the `scripts` section of your `composer.json`:
}
```

*Note: Don't forget to exclude .php_cs.dist in your build scripts.*
*Note: Don't forget to exclude `.php-cs-fixer.dist.php` and `.php-cs-fixer.cache` in your build scripts.*

## Upgrade from v0.x to v1.0

Expand Down
1 change: 0 additions & 1 deletion src/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public function getRules() : array {
'elseif' => true,
'encoding' => true,
'full_opening_tag' => true,
'fully_qualified_strict_types' => ['leading_backslash_in_global_namespace' => true],
'function_declaration' => [
'closure_function_spacing' => 'one',
],
Expand Down

0 comments on commit cf5f18d

Please sign in to comment.