Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Makefile, update README #5482

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

privatemaker
Copy link
Contributor

@privatemaker privatemaker commented Sep 19, 2023

With gracious guidance from @ChristophWurst these changes "worked for me" and seem to be current across apps 😄

fixes #5478

Signed-off-by: Private Maker <privatemaker@posteo.net>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 19, 2023
@ChristophWurst ChristophWurst changed the title drop Makefile, update README fixes #5478 drop Makefile, update README Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (4d3172f) 22.61% compared to head (933e503) 22.59%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5482      +/-   ##
============================================
- Coverage     22.61%   22.59%   -0.02%     
  Complexity      395      395              
============================================
  Files           241      241              
  Lines         11848    11854       +6     
  Branches       2306     2306              
============================================
  Hits           2679     2679              
- Misses         9169     9175       +6     
Flag Coverage Δ
javascript 13.81% <ø> (-0.01%) ⬇️
php 64.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most other NC projects still have Makefiles as well, I would wait for different opinions (especially from the ones who made the work at https://nextcloud.com/contribute/ and https://nextcloud.com/developer/ first to see what they prefer).

Otherwise we can just fix it if we keep it

README.md Outdated Show resolved Hide resolved
@privatemaker
Copy link
Contributor Author

Most other NC projects still have Makefiles as well

@tciworld the Makefile is broken and relying on files that no longer exist. It is my understanding from @ChristophWurst and other devs on server team the current approach of NC is to move away from Makefiles entirely and instruct users only to use lang specific tools manually (composer and npm).

@ChristophWurst
Copy link
Member

We chatted about it here at the conference and the developer's view seems to be that we want people to know npm and composer because they need these tools to do any meaningful changes. The makefile adds an unnecessary abstraction.

Ref nextcloud/documentation#11121

Signed-off-by: Private Maker <privatemaker@posteo.net>
@st3iny st3iny merged commit 440b903 into nextcloud:main Sep 21, 2023
36 of 40 checks passed
Copy link

github-actions bot commented May 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README documentation out of date
5 participants