-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop Makefile, update README #5482
Conversation
Signed-off-by: Private Maker <privatemaker@posteo.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5482 +/- ##
============================================
- Coverage 22.61% 22.59% -0.02%
Complexity 395 395
============================================
Files 241 241
Lines 11848 11854 +6
Branches 2306 2306
============================================
Hits 2679 2679
- Misses 9169 9175 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most other NC projects still have Makefiles as well, I would wait for different opinions (especially from the ones who made the work at https://nextcloud.com/contribute/ and https://nextcloud.com/developer/ first to see what they prefer).
Otherwise we can just fix it if we keep it
@tciworld the |
We chatted about it here at the conference and the developer's view seems to be that we want people to know npm and composer because they need these tools to do any meaningful changes. The makefile adds an unnecessary abstraction. |
Signed-off-by: Private Maker <privatemaker@posteo.net>
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
With gracious guidance from @ChristophWurst these changes "worked for me" and seem to be current across apps 😄
fixes #5478