Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dashboard): implement widget item api v2 #5417

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 17, 2023

Ref nextcloud/server#39937

The old, bundled widget has to stay until we exclusively support the corresponding server versions.

@st3iny st3iny self-assigned this Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (af4e4c1) 22.68% compared to head (130a4a8) 22.64%.
Report is 11 commits behind head on main.

❗ Current head 130a4a8 differs from pull request most recent head a00f344. Consider uploading reports for the commit a00f344 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5417      +/-   ##
============================================
- Coverage     22.68%   22.64%   -0.04%     
- Complexity      387      395       +8     
============================================
  Files           240      241       +1     
  Lines         11811    11831      +20     
  Branches       2297     2297              
============================================
  Hits           2679     2679              
- Misses         9132     9152      +20     
Flag Coverage Δ
javascript 13.84% <ø> (ø)
php 64.26% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The old, bundled widget has to stay until we exclusively support the
corresponding server versions.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny marked this pull request as ready for review September 5, 2023 09:10
@st3iny st3iny added 3. to review Waiting for reviews enhancement New feature request and removed 2. developing Work in progress labels Sep 5, 2023
@st3iny st3iny added this to the v4.6.0 milestone Sep 5, 2023
@st3iny
Copy link
Member Author

st3iny commented Sep 5, 2023

/backport to stable4.5

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Sep 5, 2023
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 5, 2023
@st3iny st3iny merged commit 4b2ca7f into main Sep 5, 2023
40 of 41 checks passed
@st3iny st3iny deleted the perf/dashboard/item-api-v2 branch September 5, 2023 10:14
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request performance 🚀
Projects
Development

Successfully merging this pull request may close these issues.

2 participants