Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move birthday calendar settings to server component #4402

Closed
wants to merge 3 commits into from
Closed

Move birthday calendar settings to server component #4402

wants to merge 3 commits into from

Conversation

cneukom
Copy link

@cneukom cneukom commented Jul 28, 2022

In combination with nextcloud/server#33397, this PR potentially closes #130.

@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature request labels Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #4402 (b01c6cb) into main (5e87d47) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head b01c6cb differs from pull request most recent head b4fadcc. Consider uploading reports for the commit b4fadcc to get more accurate results

@@             Coverage Diff              @@
##               main    #4402      +/-   ##
============================================
- Coverage     29.42%   29.36%   -0.06%     
  Complexity      330      330              
============================================
  Files           220      220              
  Lines          7702     7685      -17     
  Branches       1019     1016       -3     
============================================
- Hits           2266     2257       -9     
+ Misses         5436     5428       -8     
Flag Coverage Δ
javascript 20.43% <0.00%> (-0.09%) ⬇️
php 68.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/AppNavigation/Settings.vue 0.00% <0.00%> (ø)
src/services/caldavService.js 31.48% <ø> (-0.10%) ⬇️
src/store/settings.js 93.75% <ø> (-0.49%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Cédric Neukom added 3 commits August 15, 2022 21:59
Signed-off-by: Cédric Neukom <github@webguy.ch>
… to the server

Signed-off-by: Cédric Neukom <github@webguy.ch>
Signed-off-by: Cédric Neukom <github@webguy.ch>
@cneukom cneukom closed this by deleting the head repository Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize reminder type for automatically generated birthday events
2 participants