Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed highlighting of the current day to be more visible #395

Merged
merged 1 commit into from
Apr 9, 2017

Conversation

bbBowser
Copy link
Contributor

Changed color of current day, to be more visible on screens with bad contrast (from #ffc to #ffa)

Changed color of current day, to be more visible on screens with bad contrast (from #ffc to #ffa)
@mention-bot
Copy link

@bbBowser, thanks for your PR! By analyzing the history of the files in this pull request, we identified @georgehrke, @raghunayyar and @tcitworld to be potential reviewers.

@georgehrke
Copy link
Member

Hey :)

Thx for your contribution! :)
When submitting design pull requests please always provide before and after screenshots.

Please also explain why you think this change is necessary.

Thx :)

@bbBowser
Copy link
Contributor Author

Sorry for those short explanations ;)
I had problems to find the current day on several laptop or office screens, when the viewing angle was not perfect.
I think the current highlight has not enough contrast to fit those "not perfectly calibrated screens".
Since made it just a little darker, the overall appearance is not changed very much.

before:
grafik

after:
grafik

Thx for your patience and good work,
bbBowser

@bbBowser bbBowser changed the title Update calcontroller.js Changed highlighting of the current day to be more visible Mar 31, 2017
@tcitworld
Copy link
Member

Related #119

@georgehrke georgehrke added the 3. to review Waiting for reviews label Mar 31, 2017
@georgehrke
Copy link
Member

pls review @nextcloud/designers :)

Copy link
Member

@MariusBluem MariusBluem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it 👍

@enoch85
Copy link
Member

enoch85 commented Apr 2, 2017

OK with me as well 👍

@georgehrke
Copy link
Member

btw, I don't mean to hijack this thread, but most other calendar applications color the days of the weekend slightly grey.
Did we decide against that intentionally? If yes, why?

@enoch85
Copy link
Member

enoch85 commented Apr 2, 2017

@georgehrke Gray is better imho actually.

@tcitworld tcitworld merged commit a66b8ce into nextcloud:master Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants